Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: coerce port to number in ConnectionOptionsEnvReader #6786

Merged
merged 1 commit into from Sep 26, 2020
Merged

fix: coerce port to number in ConnectionOptionsEnvReader #6786

merged 1 commit into from Sep 26, 2020
+11 −1

Commits on Sep 25, 2020

  1. fix: coerce port to number in ConnectionOptionsEnvReader 

    the expected type of `port` in all drivers is a number - and
in MSSQL this is a problem as the underlying driver does not
properly handle a string port - so we have to parseInt

closes typeorm#6781
    @imnotjames
    imnotjames committed Sep 25, 2020
    Copy the full SHA
    5098d16 View commit details
    Browse the repository at this point in the history