Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add absolute path support to other CLI commands #6807

Merged
merged 1 commit into from Oct 1, 2020

Conversation

tomasreimers
Copy link
Contributor

Following up on #6660 and adding absolute path support to the other CLI commands (sorry it took me so long!)

This is the same change + the type change necessary to prevent a breakage (someone please correct me if I'm missing anything)!

Thanks!

Copy link
Contributor

@imnotjames imnotjames left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Until we can confirm that adding path.resolve won't break anything I think this looks good to me.

@imnotjames imnotjames mentioned this pull request Oct 1, 2020
@imnotjames imnotjames merged commit d9a76e9 into typeorm:master Oct 1, 2020
@imnotjames
Copy link
Contributor

Oh no! This broke the build.

https://app.circleci.com/pipelines/github/typeorm/typeorm/1536/workflows/83ce2f7e-0904-4b1f-a39e-7dd6e7a9f1a6/jobs/3259

src/commands/EntityCreateCommand.ts:50:21 - error TS2322: Type 'string | undefined' is not assignable to type 'string'.
  Type 'undefined' is not assignable to type 'string'.

50                     directory = connectionOptions.cli ? connectionOptions.cli.entitiesDir : undefined;
                       ~~~~~~~~~

src/commands/SubscriberCreateCommand.ts:51:21 - error TS2322: Type 'string | undefined' is not assignable to type 'string'.
  Type 'undefined' is not assignable to type 'string'.

51                     directory = connectionOptions.cli ? connectionOptions.cli.subscribersDir : undefined;
                       ~~~~~~~~~


Found 2 errors.

imnotjames added a commit to imnotjames/typeorm that referenced this pull request Oct 1, 2020
imnotjames added a commit to imnotjames/typeorm that referenced this pull request Oct 1, 2020
…reateCommand

somehow typeorm#6807 passed as a PR but failed when merged in - this fixes the issues
that cropped up after it was merged in
pleerock pushed a commit that referenced this pull request Oct 1, 2020
…reateCommand (#6824)

somehow #6807 passed as a PR but failed when merged in - this fixes the issues
that cropped up after it was merged in
imnotjames added a commit to imnotjames/typeorm that referenced this pull request Oct 1, 2020
…reateCommand

somehow typeorm#6807 passed as a PR but failed when merged in - this fixes the issues
that cropped up after it was merged in
@imnotjames imnotjames added the hacktoberfest-accepted label hacktoberfest label Oct 9, 2020
zaro pushed a commit to zaro/typeorm that referenced this pull request Jan 12, 2021
zaro pushed a commit to zaro/typeorm that referenced this pull request Jan 12, 2021
…reateCommand (typeorm#6824)

somehow typeorm#6807 passed as a PR but failed when merged in - this fixes the issues
that cropped up after it was merged in
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted label hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants