Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(migrations): add a flag to return zero from migration generation… #7309

Closed

Conversation

lev-kuznetsov
Copy link

Description of change

This adds a flag to return a zero status for migration:generate script when no changes are to be made. This flag is to allow for functionality as it was before an October 2020 commit when the non zero status was added. I have automation based on that behavior.

There flag is solely for migration:generate script, shorthand option is -z and long option is --allowEmptyMigration. Camel case seems to be in spirit with the other options there.

I did not find any separate documentation files for these flags.

Pull-Request Checklist

  • Code is up-to-date with the master branch
  • npm run lint passes with this change
  • npm run test passes with this change
  • [N/A] This pull request links relevant issues as Fixes #0000
  • [N/A] There are new or updated unit tests validating the change
  • [N/A] Documentation has been updated to reflect this change
  • The new commits follow conventions explained in CONTRIBUTING.md

…hanges

This adds a flag to return a zero status for migration:generate script when no changes are to be made. This flag is to allow for functionality as it was before an October 2020 commit when the non zero status was added. I have automation based on that behavior.
Co-authored-by: Glen <glen.84@gmail.com>
@pleerock
Copy link
Member

I think this is the same fix as in #7294
Closing, but let me know if I'm wrong.

@pleerock pleerock closed this Feb 24, 2021
@lev-kuznetsov
Copy link
Author

Not exactly, but this one will work for me, thanks!

d6df200

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants