Add missing Date to string conversion on SQLite's driver (Fix #7675) #7696
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of change
The behavior reported on the issue happened because, as stated on
typeorm/src/driver/sqlite-abstract/AbstractSqliteDriver.ts
Lines 274 to 277 in 283413d
Date objects need to be converted before being forwarded to sqlite. But, on the
escapeQueryWithParameters
method, it wasn't. I added the needed conversion and created a new test to catch the bug.Fixes #7675
Pull-Request Checklist
master
branchnpm run lint
passes with this changenpm run test
passes with this changeFixes #0000