Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: Move tablePath calculation out of the EntityMetadata class #7856

Merged
merged 2 commits into from
Jul 9, 2021
Merged

refactor: Move tablePath calculation out of the EntityMetadata class #7856

merged 2 commits into from
Jul 9, 2021

Conversation

imnotjames
Copy link
Contributor

@imnotjames imnotjames commented Jul 7, 2021 •
edited

Description of change

refactors the way tablePath is handled in EntityMetadata to use the driver's buildTableName we don't keep a list elsewhere of who supports a schema in their table name and who doesn't.

Pull-Request Checklist

  • Code is up-to-date with the master branch
  • npm run lint passes with this change
  • npm run test passes with this change
  • This pull request links relevant issues as Fixes #0000
  • There are new or updated unit tests validating the change
  • Documentation has been updated to reflect this change
  • The new commits follow conventions explained in CONTRIBUTING.md

@imnotjames imnotjames force-pushed the fix/4820/schemas-for-everyone branch 2 times, most recently from 44988eb to 58fdf08 Compare July 7, 2021 06:12
@imnotjames imnotjames changed the title fix: Allow schemas in MySQL refactor: Move tablePath calculation out of the EntityMetadata class Jul 7, 2021
@imnotjames imnotjames force-pushed the fix/4820/schemas-for-everyone branch 2 times, most recently from 025794a to 0afda57 Compare July 9, 2021 04:14
@imnotjames imnotjames force-pushed the fix/4820/schemas-for-everyone branch from 0afda57 to 69c146b Compare July 9, 2021 04:24
@imnotjames imnotjames marked this pull request as ready for review July 9, 2021 05:41
@imnotjames imnotjames merged commit 8436fdb into typeorm:master Jul 9, 2021
@imnotjames imnotjames deleted the fix/4820/schemas-for-everyone branch July 9, 2021 05:50
@imnotjames imnotjames mentioned this pull request Jul 9, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@imnotjames