Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: discard duplicated columns on update #8724

Merged
merged 2 commits into from Mar 4, 2022
Merged

fix: discard duplicated columns on update #8724

merged 2 commits into from Mar 4, 2022
+65 −1

Conversation

UyumazHakan
Copy link
Contributor

@UyumazHakan UyumazHakan commented Mar 3, 2022 •
edited

Closes: #8723

Description of change

This change is to discard duplicated columns when building an update query.
Fixes #8723

Pull-Request Checklist

  • Code is up-to-date with the master branch
  • npm run lint passes with this change
  • npm run test passes with this change
  • This pull request links relevant issues as Fixes #0000
  • There are new or updated unit tests validating the change
  • [N/A] Documentation has been updated to reflect this change
  • The new commits follow conventions explained in CONTRIBUTING.md

@pleerock pleerock merged commit 0fc093d into typeorm:master Mar 4, 2022
@pleerock
Copy link
Member

pleerock commented Mar 4, 2022

Thank you for contribution! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fail on Update when reference exists together with FK: multiple assignments to same column
2 participants
@UyumazHakan @pleerock