fix: resolve entities correctly in datasource when globs are specified #8769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pleerock please review this when possible. Unfortunately, I'm unable to run the TypeORM tests locally due some issue on my end. So, I was unable to add unit tests to cover this failure. But I did test a build of TypeORM containing this change against my applications and can confirm that #8768 is indeed resolved. |
pleerock
reviewed
Mar 22, 2022
| @@ -645,6 +646,17 @@ export class DataSource { | |||
| const flattenedEntities = ObjectUtils.mixedListToArray( | |||
| this.options.entities || [], | |||
| ) | |||
|
|
|||
| // resolve globs to the respective entity classes | |||
| flattenedEntities.push( | |||
There was a problem hiding this comment.
doesn't look like a proper solution. We already do import classes from directories above by calling buildEntityMetadatas method.
There was a problem hiding this comment.
Ah okay! Thanks for the clarification 😄
Probably need to look through the codebase more.
|
Closing in favor of #8778 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes: #8768
Description of change
In the 0.3 release, DataSource stopped resolving entities correctly when specified as Globs. This results in the data source information not being set correctly into the entities. This PR fixes it by correctly importing the classes when globs are specified.
Pull-Request Checklist
masterbranchnpm run formatto apply prettier formattingnpm run testpasses with this changeFixes #0000