Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ts-node dep version in init command #8849

Closed
wants to merge 3 commits into from

Conversation

mishagale
Copy link

Version needs to be compatible with the peerDependency version in typeorm's own package.json

Description of change

Fixes #8820

Pull-Request Checklist

  • Code is up-to-date with the master branch
  • npm run format to apply prettier formatting
  • npm run test passes with this change
  • This pull request links relevant issues as Fixes #0000
  • There are new or updated unit tests validating the change
  • Documentation has been updated to reflect this change
  • The new commits follow conventions explained in CONTRIBUTING.md

The version needs to be compatible with the peerDependency version in typeorm's own package.json

Closes typeorm#8820
@pleerock
Copy link
Member

pleerock commented Apr 5, 2022

is it finished?

@mishagale
Copy link
Author

is it finished?

The actual fix is a 1-character change, and yes, I finished that. Where I ran into problems was writing a test-case, which became pretty complicated. I've pushed the test as it is so far, but I feel it may be overcomplicated, and involved making a change to the actual init command code to make it testable, which feels like an excessive amount of added complexity for such a small fix.

@pleerock
Copy link
Member

pleerock commented Apr 5, 2022

oh no need to add test in this case

@pleerock pleerock closed this in 7b4bca7 Apr 5, 2022
@pleerock
Copy link
Member

pleerock commented Apr 5, 2022

okay I just pushed the same fix, because I need this change in order to release new version. Thank you for your efforts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

package.json generated by typeorm init has wrong version of ts-node
2 participants