Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: resolve issue with migrations and unsigned int columns in aurora-data-api #9478

Merged
merged 3 commits into from Nov 4, 2022

Conversation

mkilp
Copy link
Contributor

@mkilp mkilp commented Oct 19, 2022

Description of change

Replicates a fix that has been done for MySQL to the AWS Aurora data api driver. (#6632) Unsigned Integers cause unwanted migrations due to difference in reported width.

Fixes #9477

Pull-Request Checklist

  • Code is up-to-date with the master branch
  • npm run format to apply prettier formatting
  • npm run test passes with this change
  • This pull request links relevant issues as Fixes #0000
  • There are new or updated unit tests validating the change
  • [N/A] Documentation has been updated to reflect this change
  • The new commits follow conventions explained in CONTRIBUTING.md

@mkilp
Copy link
Contributor Author

mkilp commented Oct 26, 2022

@pleerock @NoNameProvided Any news when the open PRs are going to get merged?

@AlexMesser AlexMesser merged commit 38e0eff into typeorm:master Nov 4, 2022
@AlexMesser
Copy link
Collaborator

thank you for contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[aurora-data-api] Using unsigned int columns causes FK drop / recreation
2 participants