Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: child entities as an object not being saved correctly with cascade #9723

Closed
wants to merge 1 commit into from
Closed

fix: child entities as an object not being saved correctly with cascade #9723

wants to merge 1 commit into from

Conversation

mathieu-metral
Copy link

@mathieu-metral mathieu-metral commented Jan 20, 2023 •
edited

Description of change

Based on this fix: #6219
For child entities, if we pass an object in the save function, they are not correctly created. The getInverseEntityMetadata function only supports class instances.

Pull-Request Checklist

  • Code is up-to-date with the master branch
  • npm run format to apply prettier formatting
  • npm run test passes with this change
  • The new commits follow conventions explained in CONTRIBUTING.md

@AlexMesser
Copy link
Collaborator

could you add a test showing the original issue and how your changes fix that issue?

@pleerock
Copy link
Member

pleerock commented Apr 6, 2023

Closing as there is no response from author.

@pleerock pleerock closed this Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mathieu-metral @AlexMesser @pleerock