Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated CONTRIBUTING.md, made it better, precise, and emojified #688

Conversation

0Armaan025
Copy link
Contributor

Thanks for contributing!

First, if you are reading this, you are amazing! ⭐

I'm Armaan and I'm actively taking part in Hacktoberfest and HackSquad, I came across this repo after listening about it from my friends and various other folks, unlike other amazing repos, I found this repo to have a simple, clean and amazing "CONTRIBUTING.md" file, but I thought why not take it to next level? ;), by making it fun, precise and emojified a bit?
I mean, who doesn't like fun things?

Additional INFO: Starred✔️⭐

Thanks and regards,
Armaan.

@0Armaan025
Copy link
Contributor Author

Unsure about 'format failing'?
I believe it was in the proper coding format?

Thanks and regards,
Armaan.

@filiptammergard
Copy link
Collaborator

Thanks for this! You need to run prettier to format your code 🙂

@0Armaan025
Copy link
Contributor Author

Thanks for the review, but I believe this might be the problem with the code format checker as there is no code other than the terminal one which is supposed to be using a format.

Please highlight where the format change is required, I'd immediately do that.

Thanks and regards,
Armaan.

@filiptammergard
Copy link
Collaborator

Hey @0Armaan025, you need to run yarn format and yarn gen-readme locally and add the diff. You can do that?

@0Armaan025
Copy link
Contributor Author

I'm super unsure on how to format this then :(

@filiptammergard
Copy link
Collaborator

Might be a good opportunity to learn. Are you using VS Code as IDE?

@0Armaan025 0Armaan025 closed this Oct 27, 2023
@0Armaan025 0Armaan025 reopened this Oct 27, 2023
@0Armaan025
Copy link
Contributor Author

Yes

Copy link
Collaborator

@filiptammergard filiptammergard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed this for you now.

Thanks!

@filiptammergard filiptammergard merged commit 9e7fdb5 into typescript-cheatsheets:main Oct 31, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants