Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new option for generic forwardRefs #710

Merged
merged 3 commits into from
Mar 27, 2024

Conversation

yangshun
Copy link
Contributor

Per title.

@filiptammergard
Copy link
Collaborator

Thanks @yangshun! Can you run yarn gen-readme and include the change in README.md as well?

@yangshun
Copy link
Contributor Author

@filiptammergard Done, thanks for the quick review!

P.S. I think it'd be better to update the README automatically as a post-merge GitHub action. Would be good if I didn't have to clone the repo to make an update to the docs 😄

@filiptammergard
Copy link
Collaborator

There's also a formatting problem that needs to be fixed 🙂

P.S. I think it'd be better to update the README automatically as a post-merge GitHub action. Would be good if I didn't have to clone the repo to make an update to the docs 😄

Yeah, we tried that approach, but stumbled upon some problems. Maybe we should give it another stab. Difficult, though, if we want to enforce formatting for example.

@yangshun
Copy link
Contributor Author

Done, sorry about that.

@filiptammergard
Copy link
Collaborator

Thanks!

@filiptammergard filiptammergard merged commit 09217c9 into typescript-cheatsheets:main Mar 27, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants