Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typescript-eslint rulename to no-reference converter #243

Merged
merged 1 commit into from
Oct 20, 2019
Merged

Fix typescript-eslint rulename to no-reference converter #243

merged 1 commit into from
Oct 20, 2019

Conversation

KingDarBoja
Copy link
Collaborator

@KingDarBoja KingDarBoja commented Oct 20, 2019

PR Checklist

Overview

Provide the correct rulename to the no-reference converter.

Also, it fixes one of the four rules as stated on #153.

Copy link
Member

@JoshuaKGoldberg JoshuaKGoldberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perfect 👌 thanks @KingDarBoja!

@JoshuaKGoldberg JoshuaKGoldberg merged commit 3351415 into typescript-eslint:master Oct 20, 2019
@KingDarBoja KingDarBoja deleted the bugfix/no-reference-converter branch October 20, 2019 17:12
@KingDarBoja
Copy link
Collaborator Author

@JoshuaKGoldberg Did you saw my comment about this rule being used on the no-reference-import too? It is at the issue, please take a quick look at it 🍰

@JoshuaKGoldberg
Copy link
Member

@KingDarBoja this one? #241 (comment)

I did, but I'm not sure what action you'd like me/someone to take on that?

The cake is always appreciated though. 😸 🍰

@KingDarBoja
Copy link
Collaborator Author

@KingDarBoja this one? #241 (comment)

I did, but I'm not sure what action you'd like me/someone to take on that?

The cake is always appreciated though. 😸 🍰

I was thinking on supporting that too in another PR but I am not sure because the roadmap still states it doesn't have an equivalent rule. Also, since both TSLint rules would end up in the same ESLint rule, we would have to rely on mergers which isn't well explained on the docs.

Just saying, we can always opt to leave it for now.

Cheers!

@JoshuaKGoldberg
Copy link
Member

SGTM! Thanks 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

replace deprecated no-triple-slash-reference with triple-slash-reference
2 participants