fix(eslint-plugin): [typedef] stop enforcing rule for assignment expr…

…essions (#4958)
typescript-eslint · May 16, 2022 · 04a216c · 04a216c
1 parent 2f57f3f
commit 04a216c
Show file tree

Hide file tree

Showing 2 changed files with 30 additions and 2 deletions.
diff --git a/packages/eslint-plugin/src/rules/typedef.ts b/packages/eslint-plugin/src/rules/typedef.ts
@@ -178,7 +178,11 @@ export default util.createRule<[Options], MessageIds>({
             return;
           }
 
-          if (!node.typeAnnotation && !isForOfStatementContext(node)) {
+          if (
+            !node.typeAnnotation &&
+            !isForOfStatementContext(node) &&
+            node.parent?.type !== AST_NODE_TYPES.AssignmentExpression
+          ) {
             report(node);
           }
         },

diff --git a/packages/eslint-plugin/tests/rules/typedef.test.ts b/packages/eslint-plugin/tests/rules/typedef.test.ts
@@ -47,7 +47,31 @@ ruleTester.run('typedef', rule, {
       ],
     },
     {
-      code: 'const [a] = 1;',
+      code: '[a] = [1];',
+      options: [
+        {
+          arrayDestructuring: true,
+        },
+      ],
+    },
+    {
+      code: 'b = [a] = [1];',
+      options: [
+        {
+          arrayDestructuring: true,
+        },
+      ],
+    },
+    {
+      code: 'const [b]: [number] = ([a] = [1]);',
+      options: [
+        {
+          arrayDestructuring: true,
+        },
+      ],
+    },
+    {
+      code: 'const [a] = [1];',
       options: [
         {
           arrayDestructuring: false,