fix(eslint-plugin): [no-type-alias] unhandled type

Fixes #720
typescript-eslint · Jul 29, 2019 · 24edd61 · 24edd61
1 parent f953cbd
commit 24edd61
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 3 deletions.
diff --git a/packages/eslint-plugin/src/rules/no-type-alias.ts b/packages/eslint-plugin/src/rules/no-type-alias.ts
@@ -239,9 +239,6 @@ export default util.createRule<Options, MessageIds>({
         ) {
           reportError(type.node, type.compositionType, isTopLevel, 'Aliases');
         }
-      } else {
-        // unhandled type - shouldn't happen
-        reportError(type.node, type.compositionType, isTopLevel, 'Unhandled');
       }
     }
 

diff --git a/packages/eslint-plugin/tests/rules/no-type-alias.test.ts b/packages/eslint-plugin/tests/rules/no-type-alias.test.ts
@@ -7,6 +7,18 @@ const ruleTester = new RuleTester({
 
 ruleTester.run('no-type-alias', rule, {
   valid: [
+    {
+      code: 'type Foo = string | [number, number];',
+      options: [{ allowAliases: 'in-unions' }],
+    },
+    {
+      code: 'type Foo = string & [number, number];',
+      options: [{ allowAliases: 'in-intersections' }],
+    },
+    {
+      code: 'type Foo = string & [number, number] | [number, number, number];',
+      options: [{ allowAliases: 'in-unions-and-intersections' }],
+    },
     {
       code: "type A = 'a' & ('b' | 'c');",
       options: [{ allowAliases: 'always' }],