fix(eslint-plugin): [no-restricted-imports]: report type-only imports…

… properly (#3996)
typescript-eslint · Oct 18, 2021 · 283cdf2 · 283cdf2
1 parent 076d65a
commit 283cdf2
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 4 deletions.
diff --git a/packages/eslint-plugin/src/rules/no-restricted-imports.ts b/packages/eslint-plugin/src/rules/no-restricted-imports.ts
@@ -4,13 +4,13 @@ import {
   ArrayOfStringOrObjectPatterns,
 } from 'eslint/lib/rules/no-restricted-imports';
 import ignore, { Ignore } from 'ignore';
-import { getESLintCoreRule } from '../util/getESLintCoreRule';
 import {
   createRule,
   deepMerge,
   InferMessageIdsTypeFromRule,
   InferOptionsTypeFromRule,
 } from '../util';
+import { getESLintCoreRule } from '../util/getESLintCoreRule';
 
 const baseRule = getESLintCoreRule('no-restricted-imports');
 
@@ -150,9 +150,12 @@ export default createRule<Options, MessageIds>({
       }
     }
     function isAllowedTypeImportPattern(importSource: string): boolean {
-      return allowedImportTypeMatchers.every(matcher => {
-        return matcher.ignores(importSource);
-      });
+      return (
+        allowedImportTypeMatchers.length > 0 &&
+        allowedImportTypeMatchers.every(matcher => {
+          return matcher.ignores(importSource);
+        })
+      );
     }
 
     return {

diff --git a/packages/eslint-plugin/tests/rules/no-restricted-imports.test.ts b/packages/eslint-plugin/tests/rules/no-restricted-imports.test.ts
@@ -535,5 +535,19 @@ ruleTester.run('no-restricted-imports', rule, {
         },
       ],
     },
+    {
+      code: "import type { InvalidTestCase } from '@typescript-eslint/experimental-utils/dist/ts-eslint';",
+      options: [
+        {
+          patterns: ['@typescript-eslint/experimental-utils/dist/*'],
+        },
+      ],
+      errors: [
+        {
+          messageId: 'patterns',
+          type: AST_NODE_TYPES.ImportDeclaration,
+        },
+      ],
+    },
   ],
 });