fix(eslint-plugin): [no-unused-expressions] handle TSInstantiationExp…

…ression expression (#7831)
typescript-eslint · Oct 25, 2023 · 31988e0 · 31988e0
1 parent 6455278
commit 31988e0
Show file tree

Hide file tree

Showing 2 changed files with 41 additions and 2 deletions.
diff --git a/packages/eslint-plugin/src/rules/no-unused-expressions.ts b/packages/eslint-plugin/src/rules/no-unused-expressions.ts
@@ -1,5 +1,4 @@
-import type { TSESTree } from '@typescript-eslint/utils';
-import { AST_NODE_TYPES } from '@typescript-eslint/utils';
+import { AST_NODE_TYPES, TSESTree } from '@typescript-eslint/utils';
 
 import type {
   InferMessageIdsTypeFromRule,
@@ -58,6 +57,17 @@ export default createRule<Options, MessageIds>({
           return;
         }
 
+        if (
+          node.expression.type ===
+          TSESTree.AST_NODE_TYPES.TSInstantiationExpression
+        ) {
+          rules.ExpressionStatement({
+            ...node,
+            expression: node.expression.expression,
+          });
+          return;
+        }
+
         rules.ExpressionStatement(node);
       },
     };

diff --git a/packages/eslint-plugin/tests/rules/no-unused-expressions.test.ts b/packages/eslint-plugin/tests/rules/no-unused-expressions.test.ts
@@ -72,6 +72,10 @@ ruleTester.run('no-unused-expressions', rule, {
     `
       import('./foo').then(() => {});
     `,
+    `
+      class Foo<T> {}
+      new Foo<string>();
+    `,
     {
       code: 'foo && foo?.();',
       options: [{ allowShortCircuit: true }],
@@ -296,5 +300,30 @@ function foo() {
         },
       ]),
     },
+    {
+      code: noFormat`
+class Foo<T> {}
+Foo<string>;
+      `,
+      errors: error([
+        {
+          line: 3,
+          endLine: 3,
+          column: 1,
+          endColumn: 13,
+        },
+      ]),
+    },
+    {
+      code: 'Map<string, string>;',
+      errors: error([
+        {
+          line: 1,
+          endLine: 1,
+          column: 1,
+          endColumn: 21,
+        },
+      ]),
+    },
   ],
 });