fix(eslint-plugin): fix no-base-to-string boolean literal check

typescript-eslint · Apr 4, 2020 · 35537ad · 35537ad
1 parent 7c11bd6
commit 35537ad
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/packages/eslint-plugin/src/rules/no-base-to-string.ts b/packages/eslint-plugin/src/rules/no-base-to-string.ts
@@ -65,6 +65,10 @@ export default util.createRule({
         return Usefulness.Always;
       }
 
+      if (type.flags & ts.TypeFlags.BooleanLiteral) {
+        return Usefulness.Always;
+      }
+
       if (
         toString.declarations.every(
           ({ parent }) =>

diff --git a/packages/eslint-plugin/tests/rules/no-base-to-string.test.ts b/packages/eslint-plugin/tests/rules/no-base-to-string.test.ts
@@ -30,6 +30,10 @@ ruleTester.run('no-base-to-string', rule, {
     "'text'.toString();",
     'false.toString();',
     `
+let value = true;
+value.toString();
+    `,
+    `
 let value = 1;
 value.toString();
     `,