fix(eslint-plugin): [explicit-module-boundary-types] ignore abstract …

…setters (#2410)
typescript-eslint · Aug 20, 2020 · 3764248 · 3764248
1 parent b62331a
commit 3764248
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 1 deletion.
diff --git a/packages/eslint-plugin/src/rules/explicit-module-boundary-types.ts b/packages/eslint-plugin/src/rules/explicit-module-boundary-types.ts
@@ -427,7 +427,10 @@ export default util.createRule<Options, MessageIds>({
       const isConstructor =
         node.parent?.type === AST_NODE_TYPES.MethodDefinition &&
         node.parent.kind === 'constructor';
-      if (!isConstructor && !node.returnType) {
+      const isAbstractSetAccessor =
+        node.parent?.type === AST_NODE_TYPES.TSAbstractMethodDefinition &&
+        node.parent.kind === 'set';
+      if (!isConstructor && !isAbstractSetAccessor && !node.returnType) {
         context.report({
           node,
           messageId: 'missingReturnType',

diff --git a/packages/eslint-plugin/tests/rules/explicit-module-boundary-types.test.ts b/packages/eslint-plugin/tests/rules/explicit-module-boundary-types.test.ts
@@ -646,6 +646,11 @@ type Buz = () => (n: number) => string;
 
 export const buz: Buz = () => n => String(n);
     `,
+    `
+export abstract class Foo<T> {
+  abstract set value(element: T);
+}
+    `,
   ],
   invalid: [
     {