fix(eslint-plugin): [no-extra-parens] keep parens around call express…

…ion arguments when type arguments contain parens (#7375) * fix(eslint-plugin): [no-extra-parens] keep parens around call expression arguments when type arguments contain parens * Update packages/eslint-plugin/src/rules/no-extra-parens.ts --------- Co-authored-by: Josh Goldberg ✨ <git@joshuakgoldberg.com>
typescript-eslint · Aug 5, 2023 · 38e5e4e · 38e5e4e
1 parent 56919e4
commit 38e5e4e
Show file tree

Hide file tree

Showing 2 changed files with 34 additions and 5 deletions.
diff --git a/packages/eslint-plugin/src/rules/no-extra-parens.ts b/packages/eslint-plugin/src/rules/no-extra-parens.ts
@@ -27,6 +27,7 @@ export default util.createRule<Options, MessageIds>({
   },
   defaultOptions: ['all'],
   create(context) {
+    const sourceCode = context.getSourceCode();
     const rules = baseRule.create(context);
 
     function binaryExp(
@@ -79,11 +80,9 @@ export default util.createRule<Options, MessageIds>({
 
       if (
         node.arguments.length === 1 &&
-        node.typeArguments?.params.some(
-          param =>
-            param.type === AST_NODE_TYPES.TSImportType ||
-            param.type === AST_NODE_TYPES.TSArrayType,
-        )
+        // is there any opening parenthesis in type arguments
+        sourceCode.getTokenAfter(node.callee, util.isOpeningParenToken) !==
+          sourceCode.getTokenBefore(node.arguments[0], util.isOpeningParenToken)
       ) {
         return rule({
           ...node,

diff --git a/packages/eslint-plugin/tests/rules/no-extra-parens.test.ts b/packages/eslint-plugin/tests/rules/no-extra-parens.test.ts
@@ -515,6 +515,26 @@ f<(number | string)[]>(['a', 1])
         },
       },
     },
+    {
+      code: `
+f<(number)>(1)
+      `,
+      parserOptions: {
+        ecmaFeatures: {
+          jsx: true,
+        },
+      },
+    },
+    {
+      code: `
+f<(number) | string>(1)
+      `,
+      parserOptions: {
+        ecmaFeatures: {
+          jsx: true,
+        },
+      },
+    },
   ],
 
   invalid: [
@@ -608,6 +628,16 @@ f<(number | string)[]>(['a', 1])
         },
       ],
     },
+    {
+      code: 'a<(A) | number>((1));',
+      output: 'a<(A) | number>(1);',
+      errors: [
+        {
+          messageId: 'unexpected',
+          column: 17,
+        },
+      ],
+    },
     {
       code: 'async function f(arg: Promise<any>) { await (arg); }',
       output: 'async function f(arg: Promise<any>) { await arg; }',