feat(eslint-plugin): [no-floating-promise] don't ignore void

typescript-eslint · May 10, 2020 · 5dbc169 · 5dbc169
1 parent 3947418
commit 5dbc169
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 2 deletions.
diff --git a/packages/eslint-plugin/docs/rules/no-floating-promises.md b/packages/eslint-plugin/docs/rules/no-floating-promises.md
@@ -56,7 +56,8 @@ type Options = {
 };
 
 const defaults = {
-  ignoreVoid: false,
+  ignoreVoid: true,
+  ignoreIIFE: false,
 };
 ```
 
@@ -76,6 +77,8 @@ void returnsPromise();
 void Promise.reject('value');
 ```
 
+With this option set to `true`, and if you are using `no-void`, you should turn on the [`allowAsAStatement`](https://eslint.org/docs/rules/no-void#allowasstatement) option.
+
 ### `ignoreIIFE`
 
 This allows you to skip checking of async iife

diff --git a/packages/eslint-plugin/src/rules/no-floating-promises.ts b/packages/eslint-plugin/src/rules/no-floating-promises.ts
@@ -47,7 +47,7 @@ export default util.createRule<Options, MessageId>({
   },
   defaultOptions: [
     {
-      ignoreVoid: false,
+      ignoreVoid: true,
       ignoreIIFE: false,
     },
   ],