fix(eslint-plugin): [typedef] Support nested array destructuring with…

… type annotation (#5311)
typescript-eslint · Jul 22, 2022 · 6d19efe · 6d19efe
1 parent 48f996e
commit 6d19efe
Show file tree

Hide file tree

Showing 2 changed files with 30 additions and 2 deletions.
diff --git a/packages/eslint-plugin/src/rules/typedef.ts b/packages/eslint-plugin/src/rules/typedef.ts
@@ -150,13 +150,14 @@ export default util.createRule<[Options], MessageIds>({
     }
 
     function isAncestorHasTypeAnnotation(
-      node: TSESTree.ObjectPattern,
+      node: TSESTree.ObjectPattern | TSESTree.ArrayPattern,
     ): boolean {
       let ancestor = node.parent;
 
       while (ancestor) {
         if (
-          ancestor.type === AST_NODE_TYPES.ObjectPattern &&
+          (ancestor.type === AST_NODE_TYPES.ObjectPattern ||
+            ancestor.type === AST_NODE_TYPES.ArrayPattern) &&
           ancestor.typeAnnotation
         ) {
           return true;
@@ -181,6 +182,7 @@ export default util.createRule<[Options], MessageIds>({
           if (
             !node.typeAnnotation &&
             !isForOfStatementContext(node) &&
+            !isAncestorHasTypeAnnotation(node) &&
             node.parent?.type !== AST_NODE_TYPES.AssignmentExpression
           ) {
             report(node);

diff --git a/packages/eslint-plugin/tests/rules/typedef.test.ts b/packages/eslint-plugin/tests/rules/typedef.test.ts
@@ -70,6 +70,32 @@ ruleTester.run('typedef', rule, {
         },
       ],
     },
+    {
+      code: 'const [[a]]: number[][] = [[1]];',
+      options: [
+        {
+          arrayDestructuring: true,
+        },
+      ],
+    },
+    {
+      code: 'const foo = ([{ bar }]: { bar: string }[]) => {};',
+      options: [
+        {
+          arrayDestructuring: true,
+          objectDestructuring: true,
+        },
+      ],
+    },
+    {
+      code: 'const foo = ([{ bar }]: [{ bar: string }]) => {};',
+      options: [
+        {
+          arrayDestructuring: true,
+          objectDestructuring: true,
+        },
+      ],
+    },
     {
       code: 'const [a] = [1];',
       options: [