fix: add test coverage for TSParameterProperty and actually check it

typescript-eslint · Aug 1, 2019 · 7b10c1e · 7b10c1e
1 parent 2d53b12
commit 7b10c1e
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 1 deletion.
diff --git a/packages/eslint-plugin/src/rules/typedef.ts b/packages/eslint-plugin/src/rules/typedef.ts
@@ -76,7 +76,7 @@ export default util.createRule<[Options], MessageIds>({
             annotationNode = param.left;
             break;
           case AST_NODE_TYPES.TSParameterProperty:
-            annotationNode = undefined;
+            annotationNode = param.parameter;
             break;
           default:
             annotationNode = param;

diff --git a/packages/eslint-plugin/tests/rules/typedef.test.ts b/packages/eslint-plugin/tests/rules/typedef.test.ts
@@ -381,6 +381,17 @@ ruleTester.run('typedef', rule, {
         },
       ],
     },
+    {
+      code: `class Test {
+        public constructor(public x) { }
+      }`,
+      errors: [
+        {
+          column: 28,
+          messageId: 'expectedTypedef',
+        },
+      ],
+    },
     // Property declarations
     {
       code: `type Test = {