fix(eslint-plugin): [explicit-module-boundary-types] ignore all bodyl…

…ess setters (#2413)
typescript-eslint · Aug 21, 2020 · a53f8c6 · a53f8c6
1 parent d468cfe
commit a53f8c6
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/packages/eslint-plugin/src/rules/explicit-module-boundary-types.ts b/packages/eslint-plugin/src/rules/explicit-module-boundary-types.ts
@@ -427,10 +427,11 @@ export default util.createRule<Options, MessageIds>({
       const isConstructor =
         node.parent?.type === AST_NODE_TYPES.MethodDefinition &&
         node.parent.kind === 'constructor';
-      const isAbstractSetAccessor =
-        node.parent?.type === AST_NODE_TYPES.TSAbstractMethodDefinition &&
+      const isSetAccessor =
+        (node.parent?.type === AST_NODE_TYPES.TSAbstractMethodDefinition ||
+          node.parent?.type === AST_NODE_TYPES.MethodDefinition) &&
         node.parent.kind === 'set';
-      if (!isConstructor && !isAbstractSetAccessor && !node.returnType) {
+      if (!isConstructor && !isSetAccessor && !node.returnType) {
         context.report({
           node,
           messageId: 'missingReturnType',

diff --git a/packages/eslint-plugin/tests/rules/explicit-module-boundary-types.test.ts b/packages/eslint-plugin/tests/rules/explicit-module-boundary-types.test.ts
@@ -649,6 +649,11 @@ export const buz: Buz = () => n => String(n);
     `
 export abstract class Foo<T> {
   abstract set value(element: T);
+}
+    `,
+    `
+export declare class Foo {
+  set time(seconds: number);
 }
     `,
   ],