fix(eslint-plugin): [no-useless-empty-export] exempt .d.ts (#7718)

typescript-eslint · Oct 11, 2023 · ac397f1 · ac397f1
1 parent f81a2da
commit ac397f1
Show file tree

Hide file tree

Showing 2 changed files with 58 additions and 12 deletions.
diff --git a/packages/eslint-plugin/src/rules/no-useless-empty-export.ts b/packages/eslint-plugin/src/rules/no-useless-empty-export.ts
@@ -40,34 +40,38 @@ export default createRule({
   },
   defaultOptions: [],
   create(context) {
+    // In a definition file, export {} is necessary to make the module properly
+    // encapsulated, even when there are other exports
+    // https://github.com/typescript-eslint/typescript-eslint/issues/4975
+    if (util.isDefinitionFile(context.getFilename())) {
+      return {};
+    }
     function checkNode(
       node: TSESTree.Program | TSESTree.TSModuleDeclaration,
     ): void {
       if (!Array.isArray(node.body)) {
         return;
       }
 
-      let emptyExport: TSESTree.ExportNamedDeclaration | undefined;
+      const emptyExports: TSESTree.ExportNamedDeclaration[] = [];
       let foundOtherExport = false;
 
       for (const statement of node.body) {
         if (isEmptyExport(statement)) {
-          emptyExport = statement;
-
-          if (foundOtherExport) {
-            break;
-          }
+          emptyExports.push(statement);
         } else if (exportOrImportNodeTypes.has(statement.type)) {
           foundOtherExport = true;
         }
       }
 
-      if (emptyExport && foundOtherExport) {
-        context.report({
-          fix: fixer => fixer.remove(emptyExport!),
-          messageId: 'uselessExport',
-          node: emptyExport,
-        });
+      if (foundOtherExport) {
+        for (const emptyExport of emptyExports) {
+          context.report({
+            fix: fixer => fixer.remove(emptyExport),
+            messageId: 'uselessExport',
+            node: emptyExport,
+          });
+        }
       }
     }
 

diff --git a/packages/eslint-plugin/tests/rules/no-useless-empty-export.test.ts b/packages/eslint-plugin/tests/rules/no-useless-empty-export.test.ts
@@ -37,6 +37,35 @@ ruleTester.run('no-useless-empty-export', rule, {
     `
       export {};
     `,
+    // https://github.com/microsoft/TypeScript/issues/38592
+    {
+      code: `
+        export type A = 1;
+        export {};
+      `,
+      filename: 'foo.d.ts',
+    },
+    {
+      code: `
+        export declare const a = 2;
+        export {};
+      `,
+      filename: 'foo.d.ts',
+    },
+    {
+      code: `
+        import type { A } from '_';
+        export {};
+      `,
+      filename: 'foo.d.ts',
+    },
+    {
+      code: `
+        import { A } from '_';
+        export {};
+      `,
+      filename: 'foo.d.ts',
+    },
   ],
   invalid: [
     {
@@ -120,6 +149,19 @@ export {};
       output: `
 import _ = require('_');
 
+      `,
+    },
+    {
+      code: `
+import _ = require('_');
+export {};
+export {};
+      `,
+      errors: [error, error],
+      output: `
+import _ = require('_');
+
+
       `,
     },
   ],