fix(eslint-plugin): [no-unsafe-enum-comparison] exempt bit shift oper…

…ators (#7074) * fix: exempt bit shift operators * Add test for other bit shift operator * fix: extend regex to replace if statement * fix: use more precise regex --------- Co-authored-by: Josh Goldberg ✨ <git@joshuakgoldberg.com>
typescript-eslint · Jul 17, 2023 · b3e0e75 · b3e0e75
1 parent b62affe
commit b3e0e75
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/packages/eslint-plugin/src/rules/no-unsafe-enum-comparison.ts b/packages/eslint-plugin/src/rules/no-unsafe-enum-comparison.ts
@@ -63,7 +63,7 @@ export default util.createRule({
     }
 
     return {
-      'BinaryExpression[operator=/=|<|>/]'(
+      'BinaryExpression[operator=/^[<>!=]?={0,2}$/]'(
         node: TSESTree.BinaryExpression,
       ): void {
         const left = getTypeFromNode(node.left);

diff --git a/packages/eslint-plugin/tests/rules/no-unsafe-enum-comparison.test.ts b/packages/eslint-plugin/tests/rules/no-unsafe-enum-comparison.test.ts
@@ -292,6 +292,20 @@ ruleTester.run('strict-enums-comparison', rule, {
       num === someFunction;
       mixed === someFunction;
     `,
+    `
+      enum Fruit {
+        Apple,
+      }
+
+      const bitShift = 1 << Fruit.Apple;
+    `,
+    `
+      enum Fruit {
+        Apple,
+      }
+
+      const bitShift = 1 >> Fruit.Apple;
+    `,
   ],
   invalid: [
     {