fix: fix illegal decorator check (#6723)

* Fix illegal decorator check * Fix * Fix scope-manager tests * Fix member-ordering.test.ts * Fix no-unused-vars.test.ts * Fix explicit-member-accessibility.test.ts * Fix member-ordering-alphabetically-order.test.ts * Linting * Don't check setter getters * Implement `nodeCanBeDecorated` * Fix comment * Fix type * Revert * Fix * Use `ts.hasAmbientModifier` * Revert "Use `ts.hasAmbientModifier`" This reverts commit 04e3b73. * refactor: use `getModifiers` and `getDecorators` * Remove stub hasAmbientModifier --------- Co-authored-by: Josh Goldberg <git@joshuakgoldberg.com>
typescript-eslint · Jun 17, 2023 · c456f8c · c456f8c
1 parent 89b14f2
commit c456f8c
Show file tree

Hide file tree

Showing 29 changed files with 283 additions and 97 deletions.
diff --git a/.../declaration/TSEnumDeclaration/fixtures/_error_/decorator/snapshots/1-TSESTree-Error.shot b/.../declaration/TSEnumDeclaration/fixtures/_error_/decorator/snapshots/1-TSESTree-Error.shot
diff --git a/...declaration/TSEnumDeclaration/fixtures/_error_/decorator/snapshots/3-Alignment-Error.shot b/...declaration/TSEnumDeclaration/fixtures/_error_/decorator/snapshots/3-Alignment-Error.shot
diff --git a/...aration/TSInterfaceDeclaration/fixtures/_error_/decorator/snapshots/1-TSESTree-Error.shot b/...aration/TSInterfaceDeclaration/fixtures/_error_/decorator/snapshots/1-TSESTree-Error.shot
diff --git a/...ration/TSInterfaceDeclaration/fixtures/_error_/decorator/snapshots/3-Alignment-Error.shot b/...ration/TSInterfaceDeclaration/fixtures/_error_/decorator/snapshots/3-Alignment-Error.shot
diff --git a/...aration/TSTypeAliasDeclaration/fixtures/_error_/decorator/snapshots/1-TSESTree-Error.shot b/...aration/TSTypeAliasDeclaration/fixtures/_error_/decorator/snapshots/1-TSESTree-Error.shot
diff --git a/...ration/TSTypeAliasDeclaration/fixtures/_error_/decorator/snapshots/3-Alignment-Error.shot b/...ration/TSTypeAliasDeclaration/fixtures/_error_/decorator/snapshots/3-Alignment-Error.shot
diff --git a/...eclaration/VariableDeclaration/fixtures/_error_/decorator/snapshots/1-TSESTree-Error.shot b/...eclaration/VariableDeclaration/fixtures/_error_/decorator/snapshots/1-TSESTree-Error.shot
diff --git a/...claration/VariableDeclaration/fixtures/_error_/decorator/snapshots/3-Alignment-Error.shot b/...claration/VariableDeclaration/fixtures/_error_/decorator/snapshots/3-Alignment-Error.shot
diff --git a/...orRecovery/fixtures/_error_/decorator-on-enum-declaration/snapshots/1-TSESTree-Error.shot b/...orRecovery/fixtures/_error_/decorator-on-enum-declaration/snapshots/1-TSESTree-Error.shot
diff --git a/...rRecovery/fixtures/_error_/decorator-on-enum-declaration/snapshots/3-Alignment-Error.shot b/...rRecovery/fixtures/_error_/decorator-on-enum-declaration/snapshots/3-Alignment-Error.shot
diff --git a/...ures/errorRecovery/fixtures/_error_/decorator-on-function/snapshots/1-TSESTree-Error.shot b/...ures/errorRecovery/fixtures/_error_/decorator-on-function/snapshots/1-TSESTree-Error.shot
diff --git a/...res/errorRecovery/fixtures/_error_/decorator-on-function/snapshots/3-Alignment-Error.shot b/...res/errorRecovery/fixtures/_error_/decorator-on-function/snapshots/3-Alignment-Error.shot
diff --git a/...overy/fixtures/_error_/decorator-on-interface-declaration/snapshots/1-TSESTree-Error.shot b/...overy/fixtures/_error_/decorator-on-interface-declaration/snapshots/1-TSESTree-Error.shot
diff --git a/...very/fixtures/_error_/decorator-on-interface-declaration/snapshots/3-Alignment-Error.shot b/...very/fixtures/_error_/decorator-on-interface-declaration/snapshots/3-Alignment-Error.shot
diff --git a/...ures/errorRecovery/fixtures/_error_/decorator-on-variable/snapshots/1-TSESTree-Error.shot b/...ures/errorRecovery/fixtures/_error_/decorator-on-variable/snapshots/1-TSESTree-Error.shot
diff --git a/...res/errorRecovery/fixtures/_error_/decorator-on-variable/snapshots/3-Alignment-Error.shot b/...res/errorRecovery/fixtures/_error_/decorator-on-variable/snapshots/3-Alignment-Error.shot
diff --git a/packages/ast-spec/tests/fixtures-with-differences-errors.shot b/packages/ast-spec/tests/fixtures-with-differences-errors.shot
diff --git a/packages/eslint-plugin/tests/rules/explicit-member-accessibility.test.ts b/packages/eslint-plugin/tests/rules/explicit-member-accessibility.test.ts
@@ -1835,7 +1835,7 @@ class DecoratedClass {
   get y() {
     return this.x;
   }
-  @foo @bar() set y(@foo @bar() value: x) {
+  @foo @bar() set z(@foo @bar() value: x) {
     this.x = x;
   }
 }
@@ -1861,7 +1861,7 @@ class DecoratedClass {
   get y() {
     return this.x;
   }
-  @foo @bar() set y(@foo @bar() value: x) {
+  @foo @bar() set z(@foo @bar() value: x) {
     this.x = x;
   }
 }
@@ -1882,7 +1882,7 @@ class DecoratedClass {
   get y() {
     return this.x;
   }
-  @foo @bar() set y(@foo @bar() value: x) {
+  @foo @bar() set z(@foo @bar() value: x) {
     this.x = x;
   }
 }
@@ -1903,7 +1903,7 @@ class DecoratedClass {
   get y() {
     return this.x;
   }
-  @foo @bar() set y(@foo @bar() value: x) {
+  @foo @bar() set z(@foo @bar() value: x) {
     this.x = x;
   }
 }
@@ -1931,7 +1931,7 @@ class DecoratedClass {
   get y() {
     return this.x;
   }
-  @foo @bar() set y(@foo @bar() value: x) {
+  @foo @bar() set z(@foo @bar() value: x) {
     this.x = x;
   }
 }
@@ -1952,7 +1952,7 @@ class DecoratedClass {
   get y() {
     return this.x;
   }
-  @foo @bar() set y(@foo @bar() value: x) {
+  @foo @bar() set z(@foo @bar() value: x) {
     this.x = x;
   }
 }
@@ -1973,7 +1973,7 @@ class DecoratedClass {
   get y() {
     return this.x;
   }
-  @foo @bar() set y(@foo @bar() value: x) {
+  @foo @bar() set z(@foo @bar() value: x) {
     this.x = x;
   }
 }
@@ -2001,7 +2001,7 @@ class DecoratedClass {
   get y() {
     return this.x;
   }
-  @foo @bar() set y(@foo @bar() value: x) {
+  @foo @bar() set z(@foo @bar() value: x) {
     this.x = x;
   }
 }
@@ -2022,7 +2022,7 @@ class DecoratedClass {
   get y() {
     return this.x;
   }
-  @foo @bar() set y(@foo @bar() value: x) {
+  @foo @bar() set z(@foo @bar() value: x) {
     this.x = x;
   }
 }
@@ -2043,7 +2043,7 @@ class DecoratedClass {
   get y() {
     return this.x;
   }
-  @foo @bar() set y(@foo @bar() value: x) {
+  @foo @bar() set z(@foo @bar() value: x) {
     this.x = x;
   }
 }
@@ -2071,7 +2071,7 @@ class DecoratedClass {
   get y() {
     return this.x;
   }
-  @foo @bar() set y(@foo @bar() value: x) {
+  @foo @bar() set z(@foo @bar() value: x) {
     this.x = x;
   }
 }
@@ -2092,7 +2092,7 @@ class DecoratedClass {
   get y() {
     return this.x;
   }
-  @foo @bar() set y(@foo @bar() value: x) {
+  @foo @bar() set z(@foo @bar() value: x) {
     this.x = x;
   }
 }
@@ -2113,7 +2113,7 @@ class DecoratedClass {
   get y() {
     return this.x;
   }
-  @foo @bar() set y(@foo @bar() value: x) {
+  @foo @bar() set z(@foo @bar() value: x) {
     this.x = x;
   }
 }
@@ -2141,7 +2141,7 @@ class DecoratedClass {
   public get y() {
     return this.x;
   }
-  @foo @bar() set y(@foo @bar() value: x) {
+  @foo @bar() set z(@foo @bar() value: x) {
     this.x = x;
   }
 }
@@ -2162,7 +2162,7 @@ class DecoratedClass {
   private get y() {
     return this.x;
   }
-  @foo @bar() set y(@foo @bar() value: x) {
+  @foo @bar() set z(@foo @bar() value: x) {
     this.x = x;
   }
 }
@@ -2183,7 +2183,7 @@ class DecoratedClass {
   protected get y() {
     return this.x;
   }
-  @foo @bar() set y(@foo @bar() value: x) {
+  @foo @bar() set z(@foo @bar() value: x) {
     this.x = x;
   }
 }
@@ -2211,7 +2211,7 @@ class DecoratedClass {
   get y() {
     return this.x;
   }
-  @foo @bar() public set y(@foo @bar() value: x) {
+  @foo @bar() public set z(@foo @bar() value: x) {
     this.x = x;
   }
 }
@@ -2232,7 +2232,7 @@ class DecoratedClass {
   get y() {
     return this.x;
   }
-  @foo @bar() private set y(@foo @bar() value: x) {
+  @foo @bar() private set z(@foo @bar() value: x) {
     this.x = x;
   }
 }
@@ -2253,7 +2253,7 @@ class DecoratedClass {
   get y() {
     return this.x;
   }
-  @foo @bar() protected set y(@foo @bar() value: x) {
+  @foo @bar() protected set z(@foo @bar() value: x) {
     this.x = x;
   }
 }

diff --git a/packages/eslint-plugin/tests/rules/member-ordering.test.ts b/packages/eslint-plugin/tests/rules/member-ordering.test.ts
@@ -1455,7 +1455,7 @@ class Foo {
       code: `
 class Foo {
   constructor() {}
-  @Dec() public A(): void;
+  @Dec() public A(): void {}
   @Dec() private B: string;
   private C(): void;
   private D: string;
@@ -1474,7 +1474,7 @@ class Foo {
     {
       code: `
 class Foo {
-  @Dec() private A(): void;
+  @Dec() private A(): void {}
   @Dec() private B: string;
   constructor() {}
   private C(): void;
@@ -1511,7 +1511,7 @@ class Foo {
       code: `
 class Foo {
   public A(): string;
-  @Dec() public B(): string;
+  @Dec() public B(): string {}
   public C(): string;
 
   d: string;

diff --git a/...es/eslint-plugin/tests/rules/member-ordering/member-ordering-alphabetically-order.test.ts b/...es/eslint-plugin/tests/rules/member-ordering/member-ordering-alphabetically-order.test.ts
@@ -1982,7 +1982,7 @@ class Foo {
   b2: string;
 
   public c(): void;
-  @Dec() d(): void;
+  @Dec() d(): void {}
 }
       `,
       options: [

diff --git a/packages/eslint-plugin/tests/rules/no-unused-vars/no-unused-vars.test.ts b/packages/eslint-plugin/tests/rules/no-unused-vars/no-unused-vars.test.ts
@@ -783,8 +783,10 @@ export interface Event<T> {
     },
     // https://github.com/typescript-eslint/typescript-eslint/issues/2369
     `
-export default function (@Optional() value = []) {
-  return value;
+export class Test {
+  constructor(@Optional() value: number[] = []) {
+    console.log(value);
+  }
 }
 
 function Optional() {

diff --git a/packages/scope-manager/tests/eslint-scope/references.test.ts b/packages/scope-manager/tests/eslint-scope/references.test.ts
@@ -582,7 +582,7 @@ describe('References:', () => {
 
         declare class C {
           @deco
-          foo(): TypeC;
+          foo(): TypeC {};
         }
       `,
         {

diff --git a/packages/scope-manager/tests/fixtures/decorators/accessor.ts b/packages/scope-manager/tests/fixtures/decorators/accessor.ts
@@ -5,5 +5,5 @@ class Foo {
     return 1;
   }
   @decorator
-  set foo() {}
+  set bar(value) {}
 }