Merge branch 'main'

.cspell.json

@@ -119,6 +119,7 @@
     "serializers",
     "Sourcegraph",
     "stringification",
+    "stringly",
     "superset",
     "thenables",
     "transpiled",

.github/ISSUE_TEMPLATE/01-bug-report-plugin.yaml

@@ -1,4 +1,4 @@
-name: '🐛 Report a Bug With a Rule'
+name: '🐛 Rule Bug'
 description: 'Report a bug you encountered with a lint rule'
 title: 'Bug: [rule name here] <short description of the issue>'
 labels:

.github/ISSUE_TEMPLATE/02-enhancement-rule-option.yaml

@@ -1,4 +1,4 @@
-name: '✨ Propose a New Rule Option or Additional Checks'
+name: '✨ New Rule Option or Additional Check'
 description: 'Propose a new lint rule option or propose that a lint rule checks more cases'
 title: 'Enhancement: [rule-name] <a short description of my proposal>'
 labels:

.github/ISSUE_TEMPLATE/03-enhancement-new-rule.yaml

@@ -1,4 +1,4 @@
-name: '✨ Propose a New Rule'
+name: '✨ New Rule'
 description: 'Propose a new lint rule'
 title: 'Rule proposal: <a short description of my proposal>'
 labels:

.github/ISSUE_TEMPLATE/04-enhancement-new-base-rule-extension.yaml

@@ -1,4 +1,4 @@
-name: '✨ Propose a New Base Rule Extension'
+name: '✨ New Base Rule Extension'
 description: 'Propose a new base lint rule extension'
 title: 'Base rule extension: [rule-name] <a short description of my proposal>'
 labels:

.github/ISSUE_TEMPLATE/05-documentation-request.yml

@@ -1,4 +1,4 @@
-name: '📝 Documentation Request'
+name: '📝 Documentation'
 description: 'Request a change in documentation'
 title: 'Docs: <a short description of my proposal>'
 labels:

.github/ISSUE_TEMPLATE/06-bug-report-other.yaml

@@ -1,4 +1,4 @@
-name: '🐛 Report a Bug With Another Package'
+name: '🐛 Bug With Another Package'
 description: 'Report a bug you encountered with another one of our packages (parser, util, scope-manager, etc)'
 title: 'Bug: <short description of the issue>'
 labels:

.github/ISSUE_TEMPLATE/07-enhancement-other.yaml

@@ -1,4 +1,4 @@
-name: '✨ Propose an Enhancement With Another Package'
+name: '✨ Enhance Another Package'
 description: 'Report an enhancement to another one of our packages (parser, util, scope-manager, etc)'
 title: 'Enhancement: <a short description of my proposal>'
 labels:

.github/ISSUE_TEMPLATE/08-bug-report-complex.yaml

@@ -1,4 +1,4 @@
-name: '🐛 Report a Complex Bug With a Reproduction Repository'
+name: '🐛 Complex Bug With a Reproduction Repository'
 description: Report a complex bug you encountered by providing an isolated reproduction repository
 title: 'Bug: <short description of the issue>'
 labels:

.github/ISSUE_TEMPLATE/09-config-change.yaml

@@ -1,4 +1,4 @@
-name: '♻ Propose a Change to Preset Configurations'
+name: '♻ Preset Configurations Change'
 description: 'Propose an addition, removal, or general change to a preset config'
 title: 'Configs: <a short description of my proposal>'
 labels:

.github/ISSUE_TEMPLATE/10-repo-maintenance.yaml

@@ -1,4 +1,4 @@
-name: '🏗 Suggest an Improvement with Repository Maintenance'
+name: '🏗 Improve Repository Maintenance'
 description: Report a bug or request a feature related to developing the typescript-eslint monorepo
 title: 'Repo: <short description of the issue>'
 labels:

.github/workflows/a11y-alt-bot.yml

@@ -0,0 +1,25 @@
+name: Accessibility-alt-text-bot
+on:
+  issues:
+    types: [opened, edited]
+  pull_request:
+    types: [opened, edited]
+  issue_comment:
+    types: [created, edited]
+  discussion:
+    types: [created, edited]
+  discussion_comment:
+    types: [created, edited]
+
+permissions:
+  issues: write
+  pull-requests: write
+  discussions: write
+
+jobs:
+  accessibility_alt_text_bot:
+    name: Check alt text is set on images
+    runs-on: ubuntu-latest
+    steps:
+      - name: Get action 'github/accessibility-alt-text-bot'
+        uses: github/accessibility-alt-text-bot@v1.4.0

.github/workflows/ci.yml

@@ -151,9 +151,13 @@ jobs:
   unit_tests:
     name: Run Unit Tests
     needs: [build]
-    runs-on: ubuntu-latest
+    runs-on: ${{ matrix.os }}
     strategy:
       matrix:
+        exclude:
+          - os: windows-latest
+            node-version: 16
+        os: [ubuntu-latest, windows-latest]
         # just run on the oldest and latest supported versions and assume the intermediate versions are good
         node-version: [16, 20]
         package:

.yarn/patches/@microsoft-api-extractor-npm-7.38.0-955f1e0725.patch

@@ -0,0 +1,46 @@
+diff --git a/lib/analyzer/ExportAnalyzer.js b/lib/analyzer/ExportAnalyzer.js
+index 51f31b4f2f253d82adc9594faa58d8dc031957e0..1fddac54b08665f5a5a717fef740613ae921cb7a 100644
+--- a/lib/analyzer/ExportAnalyzer.js
++++ b/lib/analyzer/ExportAnalyzer.js
+@@ -193,7 +193,7 @@ class ExportAnalyzer {
+         const mode = specifier && ts.isStringLiteralLike(specifier)
+             ? TypeScriptInternals_1.TypeScriptInternals.getModeForUsageLocation(importOrExportDeclaration.getSourceFile(), specifier)
+             : undefined;
+-        const resolvedModule = TypeScriptInternals_1.TypeScriptInternals.getResolvedModule(importOrExportDeclaration.getSourceFile(), moduleSpecifier, mode);
++        const resolvedModule = TypeScriptInternals_1.TypeScriptInternals.getResolvedModule(this._program, importOrExportDeclaration.getSourceFile(), moduleSpecifier, mode);
+         if (resolvedModule === undefined) {
+             // The TS compiler API `getResolvedModule` cannot resolve ambient modules. Thus, to match API Extractor's
+             // previous behavior, simply treat all ambient modules as external. This bug is tracked by
+@@ -666,7 +666,7 @@ class ExportAnalyzer {
+             ts.isStringLiteralLike(importOrExportDeclaration.moduleSpecifier)
+             ? TypeScriptInternals_1.TypeScriptInternals.getModeForUsageLocation(importOrExportDeclaration.getSourceFile(), importOrExportDeclaration.moduleSpecifier)
+             : undefined;
+-        const resolvedModule = TypeScriptInternals_1.TypeScriptInternals.getResolvedModule(importOrExportDeclaration.getSourceFile(), moduleSpecifier, mode);
++        const resolvedModule = TypeScriptInternals_1.TypeScriptInternals.getResolvedModule(this._program, importOrExportDeclaration.getSourceFile(), moduleSpecifier, mode);
+         if (resolvedModule === undefined) {
+             // Encountered in https://github.com/microsoft/rushstack/issues/1914.
+             //
+diff --git a/lib/analyzer/TypeScriptInternals.js b/lib/analyzer/TypeScriptInternals.js
+index ff13db7709ccf502fe202337869d4024431636c9..217c36b0303c3bf9871edabcd48fbf6e09f18561 100644
+--- a/lib/analyzer/TypeScriptInternals.js
++++ b/lib/analyzer/TypeScriptInternals.js
+@@ -84,10 +84,16 @@ class TypeScriptInternals {
+      * Retrieves the (cached) module resolution information for a module name that was exported from a SourceFile.
+      * The compiler populates this cache as part of analyzing the source file.
+      */
+-    static getResolvedModule(sourceFile, moduleNameText, mode) {
++    static getResolvedModule(program, sourceFile, moduleNameText, mode) {
+         // Compiler internal:
+-        // https://github.com/microsoft/TypeScript/blob/v4.7.2/src/compiler/utilities.ts#L161
+-        return ts.getResolvedModule(sourceFile, moduleNameText, mode);
++        // https://github.com/microsoft/TypeScript/blob/v5.3-beta/src/compiler/types.ts#L4678
++        const result = program.getResolvedModule(
++            sourceFile,
++            moduleNameText,
++            mode
++        );
++        return result?.resolvedModule;
++  
+     }
+     /**
+      * Gets the mode required for module resolution required with the addition of Node16/nodenext

.yarn/patches/typescript-npm-5.2.2-01717e9f84.patch → .yarn/patches/typescript-npm-5.3.0-beta-33b1e90865.patch

@@ -1,8 +1,8 @@
 diff --git a/lib/typescript.d.ts b/lib/typescript.d.ts
-index ead6d07d8fb2af6aa74b790c9fd947f1062f6df4..f8dad7f06e74d7cfccfcd8fc9c5c7038a7fe4164 100644
+index d785077fd9e4eb5959c0badb857358fad09d4d3f..54f71344b098e8d46acd8dd77638c60d505bb996 100644
 --- a/lib/typescript.d.ts
 +++ b/lib/typescript.d.ts
-@@ -371,8 +371,8 @@ declare namespace ts {
+@@ -4491,8 +4491,8 @@ declare namespace ts {
          JSDocFunctionType = 324,
          JSDocVariadicType = 325,
          JSDocNamepathType = 326,
@@ -12,7 +12,7 @@ index ead6d07d8fb2af6aa74b790c9fd947f1062f6df4..f8dad7f06e74d7cfccfcd8fc9c5c7038
          JSDocComment = 327,
          JSDocText = 328,
          JSDocTypeLiteral = 329,
-@@ -738,6 +738,8 @@ declare namespace ts {
+@@ -5066,6 +5066,8 @@ declare namespace ts {
          readonly name: PropertyName;
          readonly questionToken?: QuestionToken;
          readonly type?: TypeNode;
@@ -21,7 +21,7 @@ index ead6d07d8fb2af6aa74b790c9fd947f1062f6df4..f8dad7f06e74d7cfccfcd8fc9c5c7038
      }
      interface PropertyDeclaration extends ClassElement, JSDocContainer {
          readonly kind: SyntaxKind.PropertyDeclaration;
-@@ -763,6 +765,10 @@ declare namespace ts {
+@@ -5091,6 +5093,10 @@ declare namespace ts {
          readonly parent: ObjectLiteralExpression;
          readonly name: PropertyName;
          readonly initializer: Expression;
@@ -32,7 +32,7 @@ index ead6d07d8fb2af6aa74b790c9fd947f1062f6df4..f8dad7f06e74d7cfccfcd8fc9c5c7038
      }
      interface ShorthandPropertyAssignment extends ObjectLiteralElement, JSDocContainer {
          readonly kind: SyntaxKind.ShorthandPropertyAssignment;
-@@ -770,6 +776,12 @@ declare namespace ts {
+@@ -5098,6 +5104,12 @@ declare namespace ts {
          readonly name: Identifier;
          readonly equalsToken?: EqualsToken;
          readonly objectAssignmentInitializer?: Expression;
@@ -45,7 +45,7 @@ index ead6d07d8fb2af6aa74b790c9fd947f1062f6df4..f8dad7f06e74d7cfccfcd8fc9c5c7038
      }
      interface SpreadAssignment extends ObjectLiteralElement, JSDocContainer {
          readonly kind: SyntaxKind.SpreadAssignment;
-@@ -892,6 +904,8 @@ declare namespace ts {
+@@ -5222,6 +5234,8 @@ declare namespace ts {
      }
      interface FunctionTypeNode extends FunctionOrConstructorTypeNodeBase, LocalsContainer {
          readonly kind: SyntaxKind.FunctionType;
@@ -54,7 +54,7 @@ index ead6d07d8fb2af6aa74b790c9fd947f1062f6df4..f8dad7f06e74d7cfccfcd8fc9c5c7038
      }
      interface ConstructorTypeNode extends FunctionOrConstructorTypeNodeBase, LocalsContainer {
          readonly kind: SyntaxKind.ConstructorType;
-@@ -4584,7 +4598,13 @@ declare namespace ts {
+@@ -8978,7 +8992,13 @@ declare namespace ts {
      function symbolName(symbol: Symbol): string;
      function getNameOfJSDocTypedef(declaration: JSDocTypedefTag): Identifier | PrivateIdentifier | undefined;
      function getNameOfDeclaration(declaration: Declaration | Expression | undefined): DeclarationName | undefined;
@@ -68,7 +68,7 @@ index ead6d07d8fb2af6aa74b790c9fd947f1062f6df4..f8dad7f06e74d7cfccfcd8fc9c5c7038
      function getModifiers(node: HasModifiers): readonly Modifier[] | undefined;
      /**
       * Gets the JSDoc parameter tags for the node if present.
-@@ -5110,7 +5130,13 @@ declare namespace ts {
+@@ -9508,7 +9528,13 @@ declare namespace ts {
      function isModuleName(node: Node): node is ModuleName;
      function isBinaryOperatorToken(node: Node): node is BinaryOperatorToken;
      function setTextRange<T extends TextRange>(range: T, location: TextRange | undefined): T;