fix(eslint-plugin): [no-unsafe-return] allow returning anything if ex…

…plicitly returning any (#7708) * fix(eslint-plugin): [no-unsafe-return] allow returning anything if explicitly returning any * Add test
typescript-eslint · Oct 19, 2023 · c6124b2 · c6124b2
1 parent ee4fe89
commit c6124b2
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 1 deletion.
diff --git a/packages/eslint-plugin/src/rules/no-unsafe-return.ts b/packages/eslint-plugin/src/rules/no-unsafe-return.ts
@@ -104,7 +104,13 @@ export default createRule({
       // function return type, we shouldn't complain (it's intentional, even if unsafe)
       if (functionTSNode.type) {
         for (const signature of functionType.getCallSignatures()) {
-          if (returnNodeType === signature.getReturnType()) {
+          if (
+            returnNodeType === signature.getReturnType() ||
+            util.isTypeFlagSet(
+              signature.getReturnType(),
+              ts.TypeFlags.Any | ts.TypeFlags.Unknown,
+            )
+          ) {
             return;
           }
         }

diff --git a/packages/eslint-plugin/tests/rules/no-unsafe-return.test.ts b/packages/eslint-plugin/tests/rules/no-unsafe-return.test.ts
@@ -108,6 +108,17 @@ function foo(): Set<number> {
         return new Map();
       }
     `,
+    // https://github.com/typescript-eslint/typescript-eslint/issues/3549
+    `
+      function foo(): any {
+        return [] as any[];
+      }
+    `,
+    `
+      function foo(): unknown {
+        return [] as any[];
+      }
+    `,
   ],
   invalid: [
     {