test(eslint-plugin): full tests for rule no-base-to-string

typescript-eslint · Apr 25, 2020 · c8b6838 · c8b6838
1 parent c83950c
commit c8b6838
Showing 1 changed file with 59 additions and 25 deletions.
diff --git a/packages/eslint-plugin/tests/rules/no-base-to-string.test.ts b/packages/eslint-plugin/tests/rules/no-base-to-string.test.ts
@@ -11,39 +11,58 @@ const ruleTester = new RuleTester({
   },
 });
 
+const literalListBasic: string[] = [
+  "''",
+  "'text'",
+  'true',
+  'false',
+  '1',
+  '1n',
+  '[]',
+];
+
+const literalListNeedParen: string[] = [
+  '{}.constructor()',
+  '() => {}',
+  'function() {}',
+];
+
+const literalList = [...literalListBasic, ...literalListNeedParen];
+
+const literalListWrapped = [
+  ...literalListBasic,
+  ...literalListNeedParen.map(i => `(${i})`),
+];
+
 ruleTester.run('no-base-to-string', rule, {
   valid: [
-    "`${''}`;",
-    '`${true}`;',
-    '`${[]}`;',
-    '`${function() {}}`;',
-    "'' + '';",
-    "'' + true;",
-    "'' + [];",
-    'true + true;',
-    "true + '';",
-    'true + [];',
-    '[] + [];',
-    '[] + true;',
-    "[] + '';",
-    '({}.constructor());',
-    "'text'.toString();",
-    'false.toString();',
-    `
-let value = 1;
-value.toString();
-    `,
-    `
-let value = 1n;
-value.toString();
-    `,
+    // template
+    ...literalList.map(i => `\`\${${i}}\`;`),
+
+    // operator + +=
+    ...literalListWrapped
+      .map(l => literalListWrapped.map(r => `${l} + ${r};`))
+      .reduce((pre, cur) => [...pre, ...cur]),
+
+    // toString()
+    ...literalListWrapped.map(i => `${i === '1' ? `(${i})` : i}.toString();`),
+
+    // variable toString() and template
+    ...literalList.map(
+      i => `
+        let value = ${i};
+        value.toString();
+        let text = \`\${value}\`;
+      `,
+    ),
+
     `
 function someFunction() {}
 someFunction.toString();
+let text = \`\${someFunction}\`;
     `,
     'unknownObject.toString();',
     'unknownObject.someOtherMethod();',
-    '(() => {}).toString();',
     `
 class CustomToString {
   toString() {
@@ -85,6 +104,21 @@ tag\`\${{}}\`;
         },
       ],
     },
+    {
+      code: `
+        \`\${/regex/}\`;
+        '' + /regex/;
+        /regex/.toString();
+        let value = /regex/;
+        value.toString();
+        let text = \`\${value}\`;
+      `,
+      options: [
+        {
+          ignoredTypeNames: ['RegExp'],
+        },
+      ],
+    },
   ],
   invalid: [
     {