fix(eslint-plugin): [no-magic-numbers] handle bigint in class props (#…

…4411)
typescript-eslint · Jan 17, 2022 · c8e650f · c8e650f
1 parent 253bfa3
commit c8e650f
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 1 deletion.
diff --git a/packages/eslint-plugin/src/rules/no-magic-numbers.ts b/packages/eslint-plugin/src/rules/no-magic-numbers.ts
@@ -69,7 +69,7 @@ export default util.createRule<Options, MessageIds>({
 
         // Check if the node is a readonly class property
         if (
-          typeof node.value === 'number' &&
+          (typeof node.value === 'number' || typeof node.value === 'bigint') &&
           isParentTSReadonlyPropertyDefinition(node)
         ) {
           if (options.ignoreReadonlyClassProperties) {

diff --git a/packages/eslint-plugin/tests/rules/no-magic-numbers.test.ts b/packages/eslint-plugin/tests/rules/no-magic-numbers.test.ts
@@ -53,6 +53,7 @@ class Foo {
   static readonly D = 1;
   readonly E = -1;
   readonly F = +1;
+  private readonly G = 100n;
 }
       `,
       options: [{ ignoreReadonlyClassProperties: true }],
@@ -204,6 +205,7 @@ class Foo {
   static readonly D = 4;
   readonly E = -5;
   readonly F = +6;
+  private readonly G = 100n;
 }
       `,
       options: [{ ignoreReadonlyClassProperties: false }],
@@ -256,6 +258,14 @@ class Foo {
           line: 8,
           column: 17,
         },
+        {
+          messageId: 'noMagic',
+          data: {
+            raw: '100n',
+          },
+          line: 9,
+          column: 24,
+        },
       ],
     },
   ],