chore(eslint-plugin): slight cleanup of array predicate logic

typescript-eslint · Feb 7, 2020 · ccedabf · ccedabf
1 parent 09f54a8
commit ccedabf
Showing 1 changed file with 5 additions and 5 deletions.
diff --git a/packages/eslint-plugin/src/rules/no-unnecessary-condition.ts b/packages/eslint-plugin/src/rules/no-unnecessary-condition.ts
@@ -288,7 +288,7 @@ export default createRule<Options, MessageId>({
       'some',
       'every',
     ]);
-    function shouldCheckCallback(node: TSESTree.CallExpression): boolean {
+    function isArrayPredicateFunction(node: TSESTree.CallExpression): boolean {
       const { callee } = node;
       return (
         // looks like `something.filter` or `something.find`
@@ -300,12 +300,12 @@ export default createRule<Options, MessageId>({
       );
     }
     function checkCallExpression(node: TSESTree.CallExpression): void {
-      const {
-        arguments: [callback],
-      } = node;
-      if (callback && shouldCheckCallback(node)) {
+      // If this is something like arr.filter(x => /*condition*/), check `condition`
+      if (isArrayPredicateFunction(node) && node.arguments.length) {
+        const callback = node.arguments[0]!;
         // Inline defined functions
         if (
+          callback &&
           (callback.type === AST_NODE_TYPES.ArrowFunctionExpression ||
             callback.type === AST_NODE_TYPES.FunctionExpression) &&
           callback.body