fix(eslint-plugin): [promise-function-async] Allow async get/set (#820)

typescript-eslint · Aug 23, 2019 · cddfdca · cddfdca
1 parent 92e2b31
commit cddfdca
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 0 deletions.
diff --git a/packages/eslint-plugin/src/rules/promise-function-async.ts b/packages/eslint-plugin/src/rules/promise-function-async.ts
@@ -103,6 +103,14 @@ export default util.createRule<Options, MessageIds>({
         return;
       }
 
+      if (
+        node.parent &&
+        node.parent.type === 'Property' &&
+        (node.parent.kind === 'get' || node.parent.kind === 'set')
+      ) {
+        return;
+      }
+
       context.report({
         messageId: 'missingAsync',
         node,

diff --git a/packages/eslint-plugin/tests/rules/promise-function-async.test.ts b/packages/eslint-plugin/tests/rules/promise-function-async.test.ts
@@ -63,6 +63,12 @@ const invalidAsyncModifiers = {
   },
   set asyncGetter(p: Promise<void>) {
     return p;
+  },
+  get asyncGetterFunc() {
+    return async () => new Promise<void>();
+  },
+  set asyncGetterFunc(p: () => Promise<void>) {
+    return p;
   }
 }
     `,