fix(eslint-plugin): [comma-dangle] fixed crash from undefined predica…

…te.ignore (#7223)
typescript-eslint · Jul 15, 2023 · d368164 · d368164
1 parent 7e456dc
commit d368164
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/packages/eslint-plugin/src/rules/comma-dangle.ts b/packages/eslint-plugin/src/rules/comma-dangle.ts
@@ -98,7 +98,9 @@ export default util.createRule<Options, MessageIds>({
       'always-multiline': forceCommaIfMultiline,
       'only-multiline': allowCommaIfMultiline,
       never: forbidComma,
-      ignore: undefined,
+      // https://github.com/typescript-eslint/typescript-eslint/issues/7220
+      // eslint-disable-next-line @typescript-eslint/explicit-function-return-type, @typescript-eslint/no-empty-function
+      ignore: () => {},
     };
 
     function last(nodes: TSESTree.Node[]): TSESTree.Node | null {

diff --git a/packages/eslint-plugin/tests/rules/comma-dangle.test.ts b/packages/eslint-plugin/tests/rules/comma-dangle.test.ts
@@ -76,6 +76,9 @@ ruleTester.run('comma-dangle', rule, {
     { code: 'type Foo = [string\n]', options: [{ tuples: 'only-multiline' }] },
     { code: 'type Foo = [string,\n]', options: [{ tuples: 'only-multiline' }] },
 
+    // ignore
+    { code: 'const a = <TYPE,>() => {}', options: [{ generics: 'ignore' }] },
+
     // each options
     {
       code: `