fix(eslint-plugin): [class-methods-use-this] detect a problematic cas…

…e for private/protected members if `ignoreClassesThatImplementAnInterface` is `true`
typescript-eslint · Oct 18, 2023 · d4b5aaf · d4b5aaf
1 parent 556cfc8
commit d4b5aaf
Show file tree

Hide file tree

Showing 2 changed files with 441 additions and 1 deletion.
diff --git a/packages/eslint-plugin/src/rules/class-methods-use-this.ts b/packages/eslint-plugin/src/rules/class-methods-use-this.ts
@@ -145,6 +145,16 @@ export default createRule<Options, MessageIds>({
       return oldStack;
     }
 
+    function isPublicMethod(
+      accessibility: TSESTree.Accessibility | undefined,
+    ): boolean {
+      if (!accessibility || accessibility === 'public') {
+        return true;
+      }
+
+      return false;
+    }
+
     /**
      * Check if the node is an instance method not excluded by config
      */
@@ -190,7 +200,8 @@ export default createRule<Options, MessageIds>({
         stackContext.usesThis ||
         (ignoreOverrideMethods && stackContext.member.override) ||
         (ignoreClassesThatImplementAnInterface &&
-          stackContext.class.implements != null)
+          stackContext.class.implements != null &&
+          isPublicMethod(stackContext.member.accessibility))
       ) {
         return;
       }