fix(eslint-plugin): [no-import-type-side-effects] correctly ignore ze…

…ro-specifier imports (#6444)
typescript-eslint · Feb 9, 2023 · d5a6688 · d5a6688
1 parent a9cb860
commit d5a6688
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 0 deletions.
diff --git a/packages/eslint-plugin/src/rules/no-import-type-side-effects.ts b/packages/eslint-plugin/src/rules/no-import-type-side-effects.ts
@@ -29,6 +29,10 @@ export default util.createRule<Options, MessageIds>({
       'ImportDeclaration[importKind!="type"]'(
         node: TSESTree.ImportDeclaration,
       ): void {
+        if (node.specifiers.length === 0) {
+          return;
+        }
+
         const specifiers: TSESTree.ImportSpecifier[] = [];
         for (const specifier of node.specifiers) {
           if (

diff --git a/packages/eslint-plugin/tests/rules/no-import-type-side-effects.test.ts b/packages/eslint-plugin/tests/rules/no-import-type-side-effects.test.ts
@@ -18,6 +18,7 @@ ruleTester.run('no-import-type-side-effects', rule, {
     "import type T, { U } from 'mod';",
     "import T, { type U } from 'mod';",
     "import type * as T from 'mod';",
+    "import 'mod';",
   ],
   invalid: [
     {