fix(ast-spec): remove BinaryExpressionBase

typescript-eslint · Nov 11, 2021 · dac4bab · dac4bab
1 parent 00ba611
commit dac4bab
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 15 deletions.
diff --git a/packages/ast-spec/src/base/BinaryExpressionBase.ts b/packages/ast-spec/src/base/BinaryExpressionBase.ts
diff --git a/packages/ast-spec/src/expression/AssignmentExpression/spec.ts b/packages/ast-spec/src/expression/AssignmentExpression/spec.ts
@@ -1,8 +1,8 @@
 import type { AST_NODE_TYPES } from '../../ast-node-types';
-import type { BinaryExpressionBase } from '../../base/BinaryExpressionBase';
+import type { BaseNode } from '../../base/BaseNode';
 import type { Expression } from '../../unions/Expression';
 
-export interface AssignmentExpression extends BinaryExpressionBase {
+export interface AssignmentExpression extends BaseNode {
   type: AST_NODE_TYPES.AssignmentExpression;
   operator:
     | '-='
@@ -22,4 +22,5 @@ export interface AssignmentExpression extends BinaryExpressionBase {
     | '|='
     | '||=';
   left: Expression;
+  right: Expression;
 }
diff --git a/packages/ast-spec/src/expression/BinaryExpression/spec.ts b/packages/ast-spec/src/expression/BinaryExpression/spec.ts
@@ -1,9 +1,11 @@
 import type { AST_NODE_TYPES } from '../../ast-node-types';
-import type { BinaryExpressionBase } from '../../base/BinaryExpressionBase';
+import type { BaseNode } from '../../base/BaseNode';
 import type { PrivateIdentifier } from '../../special/PrivateIdentifier/spec';
 import type { Expression } from '../../unions/Expression';
 
-export interface BinaryExpression extends BinaryExpressionBase {
+export interface BinaryExpression extends BaseNode {
   type: AST_NODE_TYPES.BinaryExpression;
+  operator: string;
   left: Expression | PrivateIdentifier;
+  right: Expression;
 }
diff --git a/packages/ast-spec/src/expression/LogicalExpression/spec.ts b/packages/ast-spec/src/expression/LogicalExpression/spec.ts
@@ -1,9 +1,10 @@
 import type { AST_NODE_TYPES } from '../../ast-node-types';
-import type { BinaryExpressionBase } from '../../base/BinaryExpressionBase';
+import type { BaseNode } from '../../base/BaseNode';
 import type { Expression } from '../../unions/Expression';
 
-export interface LogicalExpression extends BinaryExpressionBase {
+export interface LogicalExpression extends BaseNode {
   type: AST_NODE_TYPES.LogicalExpression;
   operator: '??' | '&&' | '||';
   left: Expression;
+  right: Expression;
 }