fix(eslint-plugin): [no-extra-non-null-assertion] dont report for ass…

…ertions not followed by the optional chain (#2167)
typescript-eslint · Jun 3, 2020 · e4c1834 · e4c1834
1 parent c86e2a2
commit e4c1834
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 3 deletions.
diff --git a/packages/eslint-plugin/src/rules/no-extra-non-null-assertion.ts b/packages/eslint-plugin/src/rules/no-extra-non-null-assertion.ts
@@ -1,5 +1,5 @@
-import * as util from '../util';
 import { TSESTree } from '@typescript-eslint/experimental-utils';
+import * as util from '../util';
 
 export default util.createRule({
   name: 'no-extra-non-null-assertion',
@@ -32,8 +32,8 @@ export default util.createRule({
 
     return {
       'TSNonNullExpression > TSNonNullExpression': checkExtraNonNullAssertion,
-      'OptionalMemberExpression > TSNonNullExpression': checkExtraNonNullAssertion,
-      'OptionalCallExpression > TSNonNullExpression.callee': checkExtraNonNullAssertion,
+      'OptionalMemberExpression[optional = true] > TSNonNullExpression': checkExtraNonNullAssertion,
+      'OptionalCallExpression[optional = true] > TSNonNullExpression.callee': checkExtraNonNullAssertion,
     };
   },
 });
diff --git a/packages/eslint-plugin/tests/rules/no-extra-non-null-assertion.test.ts b/packages/eslint-plugin/tests/rules/no-extra-non-null-assertion.test.ts
@@ -27,6 +27,12 @@ function foo(bar?: { n: number }) {
 }
       `,
     },
+    // https://github.com/typescript-eslint/typescript-eslint/issues/2166
+    {
+      code: `
+checksCounter?.textContent!.trim();
+      `,
+    },
   ],
   invalid: [
     {