Apply suggestions from code review

Co-authored-by: Josh Goldberg ✨ <git@joshuakgoldberg.com>
typescript-eslint · Nov 12, 2023 · e85158d · e85158d
1 parent 7b77360
commit e85158d
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/packages/eslint-plugin/docs/rules/switch-exhaustiveness-check.md b/packages/eslint-plugin/docs/rules/switch-exhaustiveness-check.md
@@ -120,7 +120,7 @@ switch (value) {
 }
 ```
 
-Since `value` is a non-union type it requires the switch case to have a default clause.
+Since `value` is a non-union type it requires the switch case to have a default clause only with `requireDefaultForNonUnion` enabled.
 
 ## When Not To Use It
 

diff --git a/packages/eslint-plugin/src/rules/switch-exhaustiveness-check.ts b/packages/eslint-plugin/src/rules/switch-exhaustiveness-check.ts
@@ -204,7 +204,7 @@ export default createRule<Options, MessageIds>({
             suggest: [
               {
                 messageId: 'addMissingCases',
-                fix(fixer): TSESLint.RuleFix | null {
+                fix(fixer): TSESLint.RuleFix {
                   return fixSwitch(fixer, node, [null]);
                 },
               },

diff --git a/packages/eslint-plugin/tests/rules/switch-exhaustiveness-check.test.ts b/packages/eslint-plugin/tests/rules/switch-exhaustiveness-check.test.ts
@@ -212,7 +212,7 @@ function test(value: ObjectUnion): number {
     // switch with default clause on non-union type
     {
       code: `
-const value: number = Math.floor(Math.random() * 3);
+declare const value: number;
 
 switch (value) {
   case 0: