Merge branch 'main' into v6

typescript-eslint · Mar 6, 2023 · f880e59 · f880e59
2 parents 994123a + 9427b7c
commit f880e59
Show file tree

Hide file tree

Showing 60 changed files with 747 additions and 220 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -3,6 +3,23 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+# [5.54.0](https://github.com/typescript-eslint/typescript-eslint/compare/v5.53.0...v5.54.0) (2023-02-27)
+
+
+### Bug Fixes
+
+* **typescript-estree:** check for relative/root paths in printing file path errors ([#6491](https://github.com/typescript-eslint/typescript-eslint/issues/6491)) ([dc14242](https://github.com/typescript-eslint/typescript-eslint/commit/dc1424298493f1ee2e5a357e103c504655546d61))
+* **website:** corect playground build issue ([#6506](https://github.com/typescript-eslint/typescript-eslint/issues/6506)) ([6aad7d3](https://github.com/typescript-eslint/typescript-eslint/commit/6aad7d3957c28e408235eb1e5d7fedccc594280f))
+
+
+### Features
+
+* **eslint-plugin:** [promise-function-async] check for promises in implicit return types ([#6330](https://github.com/typescript-eslint/typescript-eslint/issues/6330)) ([de1e5ce](https://github.com/typescript-eslint/typescript-eslint/commit/de1e5ce11250b259f1f809859eeb7eaa162e897f)), closes [#6329](https://github.com/typescript-eslint/typescript-eslint/issues/6329)
+
+
+
+
+
 # [5.53.0](https://github.com/typescript-eslint/typescript-eslint/compare/v5.52.0...v5.53.0) (2023-02-20)
 
 

diff --git a/CONTRIBUTORS.md b/CONTRIBUTORS.md
@@ -19,54 +19,42 @@ Thanks goes to these wonderful people:
     <td align="center"><a href="https://github.com/bradzacher"><img src="https://avatars.githubusercontent.com/u/7462525?v=4&size=100" width="100px;" alt=""/><br /><sub><b>Brad Zacher</b></sub></a></td>
     <td align="center"><a href="https://github.com/armano2"><img src="https://avatars.githubusercontent.com/u/625469?v=4&size=100" width="100px;" alt=""/><br /><sub><b>Armano</b></sub></a></td>
     <td align="center"><a href="https://github.com/JoshuaKGoldberg"><img src="https://avatars.githubusercontent.com/u/3335181?v=4&size=100" width="100px;" alt=""/><br /><sub><b>Josh Goldberg</b></sub></a></td>
-    <td align="center"><a href="https://github.com/MichaelDeBoey"><img src="https://avatars.githubusercontent.com/u/6643991?v=4&size=100" width="100px;" alt=""/><br /><sub><b>Michaël De Boey</b></sub></a></td>
+    <td align="center"><a href="https://github.com/a-tarasyuk"><img src="https://avatars.githubusercontent.com/u/509265?v=4&size=100" width="100px;" alt=""/><br /><sub><b>Oleksandr T.</b></sub></a></td>
   </tr>
   <tr>
+    <td align="center"><a href="https://github.com/MichaelDeBoey"><img src="https://avatars.githubusercontent.com/u/6643991?v=4&size=100" width="100px;" alt=""/><br /><sub><b>Michaël De Boey</b></sub></a></td>
     <td align="center"><a href="https://github.com/soda0289"><img src="https://avatars.githubusercontent.com/u/2373964?v=4&size=100" width="100px;" alt=""/><br /><sub><b>Reyad Attiyat</b></sub></a></td>
-    <td align="center"><a href="https://github.com/sosukesuzuki"><img src="https://avatars.githubusercontent.com/u/14838850?v=4&size=100" width="100px;" alt=""/><br /><sub><b>Sosuke Suzuki</b></sub></a></td>
+    <td align="center"><a href="https://github.com/sosukesuzuki"><img src="https://avatars.githubusercontent.com/u/14838850?v=4&size=100" width="100px;" alt=""/><br /><sub><b>SUZUKI Sosuke</b></sub></a></td>
     <td align="center"><a href="https://github.com/G-Rath"><img src="https://avatars.githubusercontent.com/u/3151613?v=4&size=100" width="100px;" alt=""/><br /><sub><b>Gareth Jones</b></sub></a></td>
     <td align="center"><a href="https://github.com/weirdpattern"><img src="https://avatars.githubusercontent.com/u/19519411?v=4&size=100" width="100px;" alt=""/><br /><sub><b>Patricio Trevino</b></sub></a></td>
-    <td align="center"><a href="https://github.com/Josh-Cena"><img src="https://avatars.githubusercontent.com/u/55398995?v=4&size=100" width="100px;" alt=""/><br /><sub><b>Joshua Chen</b></sub></a></td>
   </tr>
   <tr>
+    <td align="center"><a href="https://github.com/Josh-Cena"><img src="https://avatars.githubusercontent.com/u/55398995?v=4&size=100" width="100px;" alt=""/><br /><sub><b>Joshua Chen</b></sub></a></td>
     <td align="center"><a href="https://github.com/yeonjuan"><img src="https://avatars.githubusercontent.com/u/41323220?v=4&size=100" width="100px;" alt=""/><br /><sub><b>YeonJuan</b></sub></a></td>
     <td align="center"><a href="https://github.com/nzakas"><img src="https://avatars.githubusercontent.com/u/38546?v=4&size=100" width="100px;" alt=""/><br /><sub><b>Nicholas C. Zakas</b></sub></a></td>
     <td align="center"><a href="https://github.com/j-f1"><img src="https://avatars.githubusercontent.com/u/25517624?v=4&size=100" width="100px;" alt=""/><br /><sub><b>Jed Fox</b></sub></a></td>
-    <td align="center"><a href="https://github.com/uniqueiniquity"><img src="https://avatars.githubusercontent.com/u/9092011?v=4&size=100" width="100px;" alt=""/><br /><sub><b>Ben Lichtman</b></sub></a></td>
-    <td align="center"><a href="https://github.com/phaux"><img src="https://avatars.githubusercontent.com/u/1270987?v=4&size=100" width="100px;" alt=""/><br /><sub><b>Nikita</b></sub></a></td>
+    <td align="center"><a href="https://github.com/rafaelss95"><img src="https://avatars.githubusercontent.com/u/11965907?v=4&size=100" width="100px;" alt=""/><br /><sub><b>Rafael Santana</b></sub></a></td>
   </tr>
   <tr>
+    <td align="center"><a href="https://github.com/uniqueiniquity"><img src="https://avatars.githubusercontent.com/u/9092011?v=4&size=100" width="100px;" alt=""/><br /><sub><b>Ben Lichtman</b></sub></a></td>
+    <td align="center"><a href="https://github.com/phaux"><img src="https://avatars.githubusercontent.com/u/1270987?v=4&size=100" width="100px;" alt=""/><br /><sub><b>Nikita</b></sub></a></td>
     <td align="center"><a href="https://github.com/lonyele"><img src="https://avatars.githubusercontent.com/u/15892571?v=4&size=100" width="100px;" alt=""/><br /><sub><b>Taeheon Kim</b></sub></a></td>
     <td align="center"><a href="https://github.com/scottohara"><img src="https://avatars.githubusercontent.com/u/289327?v=4&size=100" width="100px;" alt=""/><br /><sub><b>Scott O'Hara</b></sub></a></td>
     <td align="center"><a href="https://github.com/Retsam"><img src="https://avatars.githubusercontent.com/u/2281166?v=4&size=100" width="100px;" alt=""/><br /><sub><b>Retsam</b></sub></a></td>
-    <td align="center"><a href="https://github.com/kaicataldo"><img src="https://avatars.githubusercontent.com/u/7041728?v=4&size=100" width="100px;" alt=""/><br /><sub><b>Kai Cataldo</b></sub></a></td>
-    <td align="center"><a href="https://github.com/Pajn"><img src="https://avatars.githubusercontent.com/u/817422?v=4&size=100" width="100px;" alt=""/><br /><sub><b>Rasmus Eneman</b></sub></a></td>
   </tr>
   <tr>
-    <td align="center"><a href="https://github.com/mysticatea"><img src="https://avatars.githubusercontent.com/u/1937871?v=4&size=100" width="100px;" alt=""/><br /><sub><b>Toru Nagashima</b></sub></a></td>
-    <td align="center"><a href="https://github.com/ota-meshi"><img src="https://avatars.githubusercontent.com/u/16508807?v=4&size=100" width="100px;" alt=""/><br /><sub><b>Yosuke Ota</b></sub></a></td>
+    <td align="center"><a href="https://github.com/Pajn"><img src="https://avatars.githubusercontent.com/u/817422?v=4&size=100" width="100px;" alt=""/><br /><sub><b>Rasmus Eneman</b></sub></a></td>
     <td align="center"><a href="https://github.com/JounQin"><img src="https://avatars.githubusercontent.com/u/8336744?v=4&size=100" width="100px;" alt=""/><br /><sub><b>JounQin</b></sub></a></td>
-    <td align="center"><a href="https://github.com/azz"><img src="https://avatars.githubusercontent.com/u/1297597?v=4&size=100" width="100px;" alt=""/><br /><sub><b>Lucas Azzola</b></sub></a></td>
-    <td align="center"><a href="https://github.com/SimenB"><img src="https://avatars.githubusercontent.com/u/1404810?v=4&size=100" width="100px;" alt=""/><br /><sub><b>Simen Bekkhus</b></sub></a></td>
-  </tr>
-  <tr>
-    <td align="center"><a href="https://github.com/dannyfritz"><img src="https://avatars.githubusercontent.com/u/315788?v=4&size=100" width="100px;" alt=""/><br /><sub><b>Danny Fritz</b></sub></a></td>
-    <td align="center"><a href="https://github.com/omril1"><img src="https://avatars.githubusercontent.com/u/18642549?v=4&size=100" width="100px;" alt=""/><br /><sub><b>Omri Luzon</b></sub></a></td>
-    <td align="center"><a href="https://github.com/cherryblossom000"><img src="https://avatars.githubusercontent.com/u/31467609?v=4&size=100" width="100px;" alt=""/><br /><sub><b>cherryblossom</b></sub></a></td>
-    <td align="center"><a href="https://github.com/macklinu"><img src="https://avatars.githubusercontent.com/u/2344137?v=4&size=100" width="100px;" alt=""/><br /><sub><b>Mackie Underdown</b></sub></a></td>
-    <td align="center"><a href="https://github.com/bmish"><img src="https://avatars.githubusercontent.com/u/698306?v=4&size=100" width="100px;" alt=""/><br /><sub><b>Bryan Mishkin</b></sub></a></td>
-  </tr>
-  <tr>
-    <td align="center"><a href="https://github.com/lukyth"><img src="https://avatars.githubusercontent.com/u/7040242?v=4&size=100" width="100px;" alt=""/><br /><sub><b>Kanitkorn Sujautra</b></sub></a></td>
-    <td align="center"><a href="https://github.com/sviat9440"><img src="https://avatars.githubusercontent.com/u/13107421?v=4&size=100" width="100px;" alt=""/><br /><sub><b>Sviatoslav Zaytsev</b></sub></a></td>
     <td align="center"><a href="https://github.com/Zzzen"><img src="https://avatars.githubusercontent.com/u/6630042?v=4&size=100" width="100px;" alt=""/><br /><sub><b>Zzzen</b></sub></a></td>
-    <td align="center"><a href="https://github.com/anikethsaha"><img src="https://avatars.githubusercontent.com/u/26347874?v=4&size=100" width="100px;" alt=""/><br /><sub><b>Anix</b></sub></a></td>
-    <td align="center"><a href="https://github.com/octogonz"><img src="https://avatars.githubusercontent.com/u/4673363?v=4&size=100" width="100px;" alt=""/><br /><sub><b>Pete Gonzalez</b></sub></a></td>
-  </tr>
-  <tr>
+    <td align="center"><a href="https://github.com/ddubrava"><img src="https://avatars.githubusercontent.com/u/22116465?v=4&size=100" width="100px;" alt=""/><br /><sub><b>Daniil Dubrava</b></sub></a></td>
     <td align="center"><a href="https://github.com/ldrick"><img src="https://avatars.githubusercontent.com/u/3674067?v=4&size=100" width="100px;" alt=""/><br /><sub><b>ldrick</b></sub></a></td>
-    <td align="center"><a href="https://github.com/islandryu"><img src="https://avatars.githubusercontent.com/u/65934663?v=4&size=100" width="100px;" alt=""/><br /><sub><b>SHIMA RYUHEI</b></sub></a></td>
   </tr>
+  <tr>
+    <td align="center"><a href="https://github.com/gavinbarron"><img src="https://avatars.githubusercontent.com/u/7122716?v=4&size=100" width="100px;" alt=""/><br /><sub><b>Gavin Barron</b></sub></a></td>
+    <td align="center"><a href="https://github.com/pablobirukov"><img src="https://avatars.githubusercontent.com/u/1861546?v=4&size=100" width="100px;" alt=""/><br /><sub><b>Pavel Birukov </b></sub></a></td>
+    <td align="center"><a href="https://github.com/djcsdy"><img src="https://avatars.githubusercontent.com/u/310800?v=4&size=100" width="100px;" alt=""/><br /><sub><b>Daniel Cassidy</b></sub></a></td>
+    <td align="center"><a href="https://github.com/danielnixon"><img src="https://avatars.githubusercontent.com/u/6418489?v=4&size=100" width="100px;" alt=""/><br /><sub><b>Daniel Nixon</b></sub></a></td>
+    <td align="center"><a href="https://github.com/43081j"><img src="https://avatars.githubusercontent.com/u/5677153?v=4&size=100" width="100px;" alt=""/><br /><sub><b>James Garbutt</b></sub></a></td>
 </table>
 
 <!-- markdownlint-restore -->

diff --git a/docs/contributing/Pull_Requests.mdx b/docs/contributing/Pull_Requests.mdx
@@ -74,4 +74,10 @@ We generally review PRs oldest to newest, unless we consider a newer PR higher p
 
 Once we have reviewed your PR, we will provide any feedback that needs addressing.
 If you feel a requested change is wrong, don't be afraid to discuss with us in the comments.
-Once the feedback is addressed, and the PR is reviewed, we'll ensure the branch is up to date with `main`, and merge it for you.
+
+Please post comments as [line comments](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/commenting-on-a-pull-request#adding-line-comments-to-a-pull-request) when possible, so that they can be threaded.
+You can [resolve conversations](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/commenting-on-a-pull-request#resolving-conversations) on your own when you feel they're resolved - no need to comment explicitly and/or wait for a maintainer.
+
+Once you've addressed all our feedback by making code changes and/or started a followup discussion, [re-request review](https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/about-pull-request-reviews#re-requesting-a-review) from each maintainer whose feedback you addressed.
+
+Once the feedback is addressed, and the PR is approved, we'll ensure the branch is up to date with `main`, and merge it for you.
diff --git a/docs/linting/Troubleshooting.mdx b/docs/linting/Troubleshooting.mdx
@@ -243,7 +243,7 @@ See [this issue comment](https://github.com/typescript-eslint/typescript-eslint/
 
 ### I get `no-unsafe-*` complaints for cross-file changes
 
-See [Changes to one file are not reflected in linting other files in my IDE](#changes-to-one-file-are-not-reflected-in-linting-other-files-in-my-ide).
+See [Changes to one file are not reflected in linting other files in my IDE](#changes-to-one-file-are-not-reflected-when-linting-other-files-in-my-ide).
 Rules such as [`no-unsafe-argument`](https://typescript-eslint.io/rules/no-unsafe-argument), [`no-unsafe-assignment`](https://typescript-eslint.io/rules/no-unsafe-assignment), and [`no-unsafe-call`](https://typescript-eslint.io/rules/no-unsafe-call) are often impacted.
 
 ## My linting feels really slow

diff --git a/docs/linting/troubleshooting/Formatting.mdx b/docs/linting/troubleshooting/Formatting.mdx
@@ -6,17 +6,6 @@ title: What About Formatting?
 We strongly recommend against using ESLint for formatting.
 We strongly recommend using [Prettier](https://prettier.io), [dprint](https://dprint.dev), or an equivalent instead.
 
-## ESLint Core and Formatting
-
-Per [ESLint's 2020 Changes to Rule Policies blog post](https://eslint.org/blog/2020/05/changes-to-rules-policies#what-are-the-changes):
-
-> Stylistic rules are frozen - we won't be adding any more options to stylistic rules.
-> We've learned that there's no way to satisfy everyone's personal preferences, and most of the rules already have a lot of difficult-to-understand options.
-> Stylistic rules are those related to spacing, conventions, and generally anything that does not highlight an error or a better way to do something.
-
-We support the ESLint team's decision and backing logic to move away from stylistic rules.
-With the exception of bug fixes, no new formatting-related pull requests will be accepted into typescript-eslint.
-
 ## Formatters vs. Linters
 
 **Formatters** are tools that verify and correct whitespace issues in code, such as spacing and newlines.
@@ -40,7 +29,10 @@ Modern formatters such as Prettier are architected in a way that applies formatt
 
 ### Suggested Usage - Prettier
 
-We recommend using [`eslint-config-prettier`](https://github.com/prettier/eslint-config-prettier) to disable formatting rules in your ESLint configuration.
+Neither typescript-eslint nor ESLint core enable any formatting-related rules in any recommended presets.
+However, some third party plugin configurations may still enable that bad practice.
+
+If you see formatting rules enabled in your ESLint configuration, we recommend using [`eslint-config-prettier`](https://github.com/prettier/eslint-config-prettier) to disable formatting rules in your ESLint configuration.
 You can then configure your formatter separately from ESLint.
 
 Using this config by adding it to the end of your `extends`:
@@ -50,6 +42,7 @@ module.exports = {
   extends: [
     'eslint:recommended',
     'plugin:@typescript-eslint/recommended',
+    'other-configuration-that-enables-formatting-rules',
     // Add this line
     'prettier',
   ],
@@ -59,4 +52,21 @@ module.exports = {
 };
 ```
 
-Note that even if you don't use `prettier`, you can use `eslint-config-prettier` as it exclusively turns **off** all formatting rules.
+Note that even if you use a formatter other than `prettier`, you can use `eslint-config-prettier` as it exclusively turns **off** all formatting rules.
+
+## ESLint Core and Formatting
+
+Most lint rules fall into one of two to three categories:
+
+- **Logical**: Rules that care about the logic in runtime behavior of code (such as missing `await`s or invalid logical checks).
+- **Stylistic**: Rules that care about style concerns which do impact runtime behavior of code, but generally not logic. These are mostly around naming or which roughly-equivalent syntax constructs to use (such as function declarations vs. arrow functions).
+  - **Formatting**: Stylistic rules that care only about trivia (semicolons, whitespace, etc.) without impacting the runtime behavior of the code. These rules conflict with dedicated formatters such as Prettier.
+
+Per [ESLint's 2020 Changes to Rule Policies blog post](https://eslint.org/blog/2020/05/changes-to-rules-policies#what-are-the-changes), ESLint itself has moved away from _stylistic_ rules, including _formatting_ rules:
+
+> Stylistic rules are frozen - we won't be adding any more options to stylistic rules.
+> We've learned that there's no way to satisfy everyone's personal preferences, and most of the rules already have a lot of difficult-to-understand options.
+> Stylistic rules are those related to spacing, conventions, and generally anything that does not highlight an error or a better way to do something.
+
+We support the ESLint team's decision and backing logic to move away from _formatting_ and _stylistic_ rules.
+With the exception of bug fixes, no new formatting- or stylistic-related pull requests will be accepted into typescript-eslint.
diff --git a/lerna.json b/lerna.json
@@ -1,5 +1,5 @@
 {
-  "version": "5.53.0",
+  "version": "5.54.0",
   "npmClient": "yarn",
   "useWorkspaces": true,
   "stream": true

diff --git a/package.json b/package.json
@@ -114,6 +114,7 @@
     "typescript": ">=4.2.4 <5.0.0"
   },
   "resolutions": {
+    "@typescript-eslint/experimental-utils": "file:./packages/utils",
     "typescript": "~4.9.5",
     "@types/node": "^18.11.9",
     "@jest/reporters": "^29",

diff --git a/packages/ast-spec/CHANGELOG.md b/packages/ast-spec/CHANGELOG.md
@@ -3,6 +3,14 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+# [5.54.0](https://github.com/typescript-eslint/typescript-eslint/compare/v5.53.0...v5.54.0) (2023-02-27)
+
+**Note:** Version bump only for package @typescript-eslint/ast-spec
+
+
+
+
+
 # [5.53.0](https://github.com/typescript-eslint/typescript-eslint/compare/v5.52.0...v5.53.0) (2023-02-20)
 
 **Note:** Version bump only for package @typescript-eslint/ast-spec

diff --git a/packages/ast-spec/package.json b/packages/ast-spec/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@typescript-eslint/ast-spec",
-  "version": "5.53.0",
+  "version": "5.54.0",
   "description": "Complete specification for the TypeScript-ESTree AST",
   "private": true,
   "keywords": [

diff --git a/packages/eslint-plugin-internal/CHANGELOG.md b/packages/eslint-plugin-internal/CHANGELOG.md
@@ -3,6 +3,14 @@
 All notable changes to this project will be documented in this file.
 See [Conventional Commits](https://conventionalcommits.org) for commit guidelines.
 
+# [5.54.0](https://github.com/typescript-eslint/typescript-eslint/compare/v5.53.0...v5.54.0) (2023-02-27)
+
+**Note:** Version bump only for package @typescript-eslint/eslint-plugin-internal
+
+
+
+
+
 # [5.53.0](https://github.com/typescript-eslint/typescript-eslint/compare/v5.52.0...v5.53.0) (2023-02-20)
 
 **Note:** Version bump only for package @typescript-eslint/eslint-plugin-internal

diff --git a/packages/eslint-plugin-internal/package.json b/packages/eslint-plugin-internal/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@typescript-eslint/eslint-plugin-internal",
-  "version": "5.53.0",
+  "version": "5.54.0",
   "private": true,
   "main": "dist/index.js",
   "scripts": {
@@ -14,9 +14,9 @@
   },
   "dependencies": {
     "@types/prettier": "*",
-    "@typescript-eslint/scope-manager": "5.53.0",
-    "@typescript-eslint/type-utils": "5.53.0",
-    "@typescript-eslint/utils": "5.53.0",
+    "@typescript-eslint/scope-manager": "5.54.0",
+    "@typescript-eslint/type-utils": "5.54.0",
+    "@typescript-eslint/utils": "5.54.0",
     "prettier": "*"
   }
 }