Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(typescript-estree): align nodes with estree 2020 #1389

Merged
merged 11 commits into from May 10, 2020
Merged

feat(typescript-estree): align nodes with estree 2020 #1389

merged 11 commits into from May 10, 2020

Conversation

armano2
Copy link
Member

@armano2 armano2 commented Dec 29, 2019 •
edited by bradzacher

BREAKING CHANGE:

This PR aims to align new nodes with es2020 spec, mainly BigIntLiteral becomes Literal type with additional field bigint and ImportExpression is used instead of CallExpression.

https://github.com/estree/estree/blob/master/es2020.md

TODO/ISSUES:

  • update Bigint implementation
  • update ImportExpression implementation
  • update snapshots generation to support bigint
  • drop node 8

dropped:

Fixes #1999
Fixes #1950

@armano2 armano2 added DO NOT MERGE PRs which should not be merged yet dependencies Issue about dependencies of the package labels Dec 29, 2019
@typescript-eslint

This comment has been minimized.

Sign in to view
@armano2 armano2 added package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin package: typescript-estree Issues related to @typescript-eslint/typescript-estree external This issue is with another package, not typescript-eslint itself and removed external This issue is with another package, not typescript-eslint itself labels Dec 29, 2019
@armano2 armano2 added this to the 3.0.0 milestone Dec 29, 2019
@armano2 armano2 changed the title fix(typescript-estree): align BigIntLiteral with estree spec feat(typescript-estree): align BigIntLiteral with estree spec Dec 30, 2019
@armano2 armano2 changed the title feat(typescript-estree): align BigIntLiteral with estree spec feat(typescript-estree): align node with estree 2020 spec Dec 30, 2019
@armano2 armano2 changed the title feat(typescript-estree): align node with estree 2020 spec feat(typescript-estree): align node with estree@2020 Dec 30, 2019
@armano2 armano2 changed the title feat(typescript-estree): align node with estree@2020 feat(typescript-estree): align node with estree-2020 Dec 30, 2019
@armano2 armano2 changed the title feat(typescript-estree): align node with estree-2020 feat(typescript-estree): align nodes with estree-2020 Dec 30, 2019
@armano2 armano2 changed the title feat(typescript-estree): align nodes with estree-2020 feat(typescript-estree): align nodes with estree 2020 Dec 30, 2019
@armano2 armano2 added the tests anything to do with testing label Dec 30, 2019
@bradzacher bradzacher added enhancement New feature or request and removed dependencies Issue about dependencies of the package package: eslint-plugin Issues related to @typescript-eslint/eslint-plugin package: typescript-estree Issues related to @typescript-eslint/typescript-estree tests anything to do with testing labels Dec 31, 2019
@armano2 armano2 mentioned this pull request Dec 31, 2019
Merged
@armano2 armano2 added the blocked by another PR PRs which are ready to go but waiting on another PR label Jan 2, 2020
@armano2 armano2 self-assigned this Jan 9, 2020
@armano2 armano2 removed the blocked by another PR PRs which are ready to go but waiting on another PR label Jan 9, 2020
@armano2 armano2 marked this pull request as ready for review January 9, 2020 22:21
@bradzacher bradzacher added breaking change This change will require a new major version to be released and removed DO NOT MERGE PRs which should not be merged yet labels Jan 9, 2020
@codecov
Copy link

codecov bot commented Jan 9, 2020 •
edited

Codecov Report

Merging #1389 into v3 will decrease coverage by 0.04%.
The diff coverage is 85.71%.

@@            Coverage Diff             @@
##               v3    #1389      +/-   ##
==========================================
- Coverage   93.78%   93.74%   -0.05%     
==========================================
  Files         172      172              
  Lines        7808     7813       +5     
  Branches     2242     2245       +3     
==========================================
+ Hits         7323     7324       +1     
- Misses        227      228       +1     
- Partials      258      261       +3
Flag Coverage Δ
#unittest 93.74% <85.71%> (-0.05%) ⬇️
Impacted Files Coverage Δ
...ges/eslint-plugin/src/rules/no-inferrable-types.ts 93.10% <ø> (ø)
...s/eslint-plugin/src/rules/prefer-optional-chain.ts 95.23% <ø> (ø)
...pt-estree/src/ts-estree/estree-to-ts-node-types.ts 100.00% <ø> (ø)
packages/typescript-estree/src/visitor-keys.ts 100.00% <ø> (ø)
packages/typescript-estree/src/convert.ts 98.60% <83.33%> (-0.55%) ⬇️
...t-plugin/src/rules/class-literal-property-style.ts 100.00% <100.00%> (ø)
.../typescript-estree/src/ts-estree/ast-node-types.ts 100.00% <100.00%> (ø)

@armano2 armano2 added the package: typescript-estree Issues related to @typescript-eslint/typescript-estree label Jan 13, 2020
@bradzacher bradzacher changed the base branch from master to v3 May 10, 2020 00:23
@bradzacher bradzacher linked an issue May 10, 2020 that may be closed by this pull request
Conform dynamic imports import('a') to the new ESTree spec #1950
Closed
@bradzacher bradzacher linked an issue May 10, 2020 that may be closed by this pull request
Conform bigint literals to the new ESTree spec #1999
Closed
@bradzacher bradzacher merged commit 9b4aac0 into typescript-eslint:v3 May 10, 2020
bradzacher pushed a commit that referenced this pull request May 11, 2020
@armano2 @bradzacher
feat(typescript-estree): align nodes with estree 2020 (#1389)
a6cf3da
bradzacher pushed a commit that referenced this pull request May 14, 2020
@armano2 @bradzacher
feat(typescript-estree): align nodes with estree 2020 (#1389)
b0b8fa0
bradzacher pushed a commit that referenced this pull request May 17, 2020
@armano2 @bradzacher
feat(typescript-estree): align nodes with estree 2020 (#1389)
abf0354
bradzacher pushed a commit that referenced this pull request May 21, 2020
@armano2 @bradzacher
feat(typescript-estree): align nodes with estree 2020 (#1389)
aff5b62
@fisker
Copy link
Contributor

fisker commented May 22, 2020

Can't parse BigInt 200_200n

@bradzacher
Copy link
Member

please don't comment on closed PRs - file a new issue instead, as per our contributing guidelines

https://github.com/typescript-eslint/typescript-eslint/blob/master/CONTRIBUTING.md#raising-issues

@typescript-eslint typescript-eslint locked as resolved and limited conversation to collaborators May 22, 2020
@armano2 armano2 deleted the spec-alignment branch February 13, 2021 15:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees

@armano2 armano2

Labels
breaking change This change will require a new major version to be released enhancement New feature or request package: typescript-estree Issues related to @typescript-eslint/typescript-estree
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.

Conform bigint literals to the new ESTree spec Conform dynamic imports import('a') to the new ESTree spec
3 participants
@armano2 @fisker @bradzacher