Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(typescript-estree): correct storing regexp in snapshots #1393

Merged
merged 7 commits into from Jan 2, 2020
Merged

test(typescript-estree): correct storing regexp in snapshots #1393

merged 7 commits into from Jan 2, 2020

Conversation

armano2
Copy link
Member

@armano2 armano2 commented Dec 31, 2019

  • drop usage of JSON parse/stringify in tests

This change fixes issue with comparing regexp fields in snapshots and alignment tests.

This code has been extracted from #1389

@typescript-eslint

This comment has been minimized.

packages/typescript-estree/tools/test-utils.ts Outdated Show resolved Hide resolved
packages/typescript-estree/tools/test-utils.ts Outdated Show resolved Hide resolved
packages/typescript-estree/tools/test-utils.ts Outdated Show resolved Hide resolved
packages/typescript-estree/tools/test-utils.ts Outdated Show resolved Hide resolved
packages/typescript-estree/tools/test-utils.ts Outdated Show resolved Hide resolved
packages/typescript-estree/tools/test-utils.ts Outdated Show resolved Hide resolved
packages/typescript-estree/tools/test-utils.ts Outdated Show resolved Hide resolved
@bradzacher bradzacher added the tests anything to do with testing label Jan 2, 2020
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - thanks for this

@codecov
Copy link

codecov bot commented Jan 2, 2020

Codecov Report

Merging #1393 into master will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master    #1393   +/-   ##
=======================================
  Coverage   94.11%   94.11%           
=======================================
  Files         140      140           
  Lines        6028     6028           
  Branches     1709     1709           
=======================================
  Hits         5673     5673           
  Misses        191      191           
  Partials      164      164
Impacted Files Coverage Δ
packages/typescript-estree/src/parser.ts 94.06% <ø> (ø) ⬆️
...kages/eslint-plugin/src/rules/no-dynamic-delete.ts 100% <0%> (ø) ⬆️
...nt-plugin/src/rules/space-before-function-paren.ts 100% <0%> (ø) ⬆️
...nt-plugin/src/rules/no-untyped-public-signature.ts 100% <0%> (ø) ⬆️

@bradzacher bradzacher merged commit c5ffe88 into typescript-eslint:master Jan 2, 2020
@armano2 armano2 deleted the snapshot-regexp branch January 2, 2020 19:22
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 20, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
tests anything to do with testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants