Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin): no-empty-interface autofix #1865

Merged
merged 2 commits into from Apr 8, 2020
Merged

fix(eslint-plugin): no-empty-interface autofix #1865

merged 2 commits into from Apr 8, 2020

Conversation

greyscaled
Copy link
Contributor

Summary

Ensures TypeParams are copied in autofix action for no-empty-interface

Commit details

  • Ensures type params are included in the autofix output
  • Adds test case derived from 1864

Resolves: #1864

- Ensures type params are included in the autofix output
- Adds test case derived from #1864

Resolves: #1864
@typescript-eslint
Copy link
Contributor

Thanks for the PR, @vapurrmaid!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@codecov
Copy link

codecov bot commented Apr 8, 2020

Codecov Report

Merging #1865 into master will increase coverage by 0.00%.
The diff coverage is 100.00%.

@@           Coverage Diff           @@
##           master    #1865   +/-   ##
=======================================
  Coverage   94.71%   94.72%           
=======================================
  Files         161      161           
  Lines        7347     7350    +3     
  Branches     2103     2104    +1     
=======================================
+ Hits         6959     6962    +3     
  Misses        165      165           
  Partials      223      223           
Flag Coverage Δ
#unittest 94.72% <100.00%> (+<0.01%) ⬆️
Impacted Files Coverage Δ
...ages/eslint-plugin/src/rules/no-empty-interface.ts 100.00% <100.00%> (ø)

@bradzacher bradzacher added the bug Something isn't working label Apr 8, 2020
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice and easy.
one minor change, and then we're good to go.

thanks for doing this.

packages/eslint-plugin/src/rules/no-empty-interface.ts Outdated Show resolved Hide resolved
@bradzacher bradzacher added the awaiting response Issues waiting for a reply from the OP or another party label Apr 8, 2020
Co-Authored-By: Brad Zacher <brad.zacher@gmail.com>
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@bradzacher bradzacher removed the awaiting response Issues waiting for a reply from the OP or another party label Apr 8, 2020
@bradzacher bradzacher merged commit 829a2f7 into typescript-eslint:master Apr 8, 2020
@greyscaled greyscaled deleted the eslint-plugin-empty-interface-autofix branch April 8, 2020 16:51
@astorije
Copy link
Contributor

astorije commented Apr 9, 2020

You people rock, thank you!!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[@typescript-eslint/no-empty-interface] Auto-fixer deletes generic type info
4 participants