Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin): [no-extra-non-null-assertion] dont report for assertions not followed by the optional chain #2167

Merged
merged 1 commit into from Jun 3, 2020

Conversation

bradzacher
Copy link
Member

Fixes #2166

@bradzacher bradzacher added the bug Something isn't working label Jun 3, 2020
@typescript-eslint
Copy link
Contributor

Thanks for the PR, @bradzacher!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@codecov
Copy link

codecov bot commented Jun 3, 2020

Codecov Report

Merging #2167 into master will decrease coverage by 0.07%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2167      +/-   ##
==========================================
- Coverage   93.55%   93.47%   -0.08%     
==========================================
  Files         171      171              
  Lines        7799     7813      +14     
  Branches     2225     2229       +4     
==========================================
+ Hits         7296     7303       +7     
  Misses        244      244              
- Partials      259      266       +7     
Flag Coverage Δ
#unittest 93.47% <100.00%> (-0.08%) ⬇️
Impacted Files Coverage Δ
...nt-plugin/src/rules/no-extra-non-null-assertion.ts 100.00% <100.00%> (ø)
...kages/eslint-plugin/src/rules/no-empty-function.ts 84.00% <0.00%> (-4.47%) ⬇️
packages/eslint-plugin-tslint/src/rules/config.ts 97.36% <0.00%> (-2.64%) ⬇️
...es/eslint-plugin/src/rules/no-use-before-define.ts 97.14% <0.00%> (-1.43%) ⬇️
packages/eslint-plugin/src/util/types.ts 81.21% <0.00%> (-1.22%) ⬇️
...plugin/src/rules/explicit-module-boundary-types.ts 89.23% <0.00%> (-0.70%) ⬇️
packages/parser/src/analyze-scope.ts 95.13% <0.00%> (-0.38%) ⬇️
...nt-plugin/src/rules/indent-new-do-not-use/index.ts 98.13% <0.00%> (-0.27%) ⬇️
...s/eslint-plugin/src/rules/prefer-optional-chain.ts 95.09% <0.00%> (ø)
.../experimental-utils/src/eslint-utils/RuleTester.ts 9.09% <0.00%> (+0.20%) ⬆️
... and 1 more

@bradzacher bradzacher merged commit e4c1834 into master Jun 3, 2020
@bradzacher bradzacher deleted the 2166-nenna-bug branch June 3, 2020 17:21
@fregante
Copy link
Contributor

fregante commented Jun 3, 2020

Thanks Brad ✨

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 4, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[no-extra-non-null-assertion] incorrect report for assertion in an optional chain
2 participants