New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(eslint-plugin): handle missing message IDs in eslint v5/v6 #2461
fix(eslint-plugin): handle missing message IDs in eslint v5/v6 #2461
Conversation
Thanks for the PR, @esetnik! typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community. The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately. Thanks again! 🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day. |
Codecov Report
@@ Coverage Diff @@
## master #2461 +/- ##
==========================================
- Coverage 92.94% 92.83% -0.12%
==========================================
Files 289 289
Lines 9272 9283 +11
Branches 2583 2594 +11
==========================================
Hits 8618 8618
Misses 320 320
- Partials 334 345 +11
Flags with carried forward coverage won't be shown. Click here to find out more.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just went through and double checked all the rules. Theres a small number you can revert as they have had message ids since pre v5.
The rest are good. Thanks for doing this!
missed a few of the v4 ones - the comments are (annoyingly) hidden under the fold by github |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM - thanks for doing this!
Fixes #2451