Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin): [explicit-module-boundary-types] ignore functions exported within typed object/array literals #2805

Conversation

pvanagtmaal
Copy link
Contributor

Fixes #2183 by looking for the Property value's ancestor type instead of the Property's ancestor itself.

@typescript-eslint
Copy link
Contributor

Thanks for the PR, @pvanagtmaal!

typescript-eslint is a 100% community driven project, and we are incredibly grateful that you are contributing to that community.

The core maintainers work on this in their personal time, so please understand that it may not be possible for them to review your work immediately.

Thanks again!


🙏 Please, if you or your company is finding typescript-eslint valuable, help us sustain the project by sponsoring it transparently on https://opencollective.com/typescript-eslint. As a thank you, your profile/company logo will be added to our main README which receives thousands of unique visitors per day.

@codecov
Copy link

codecov bot commented Nov 24, 2020

Codecov Report

Merging #2805 (8e0fce3) into master (a8227a6) will decrease coverage by 0.00%.
The diff coverage is 50.00%.

@@            Coverage Diff             @@
##           master    #2805      +/-   ##
==========================================
- Coverage   92.76%   92.76%   -0.01%     
==========================================
  Files         301      301              
  Lines       10150    10152       +2     
  Branches     2870     2871       +1     
==========================================
+ Hits         9416     9417       +1     
  Misses        345      345              
- Partials      389      390       +1     
Flag Coverage Δ
unittest 92.76% <50.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...plugin/src/rules/explicit-module-boundary-types.ts 88.74% <50.00%> (-0.53%) ⬇️

@bradzacher bradzacher added the bug Something isn't working label Nov 24, 2020
Copy link
Member

@bradzacher bradzacher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@bradzacher bradzacher changed the title fix(eslint-plugin): fix issue #2183 fix(eslint-plugin): [explicit-module-boundary-types] ignore functions exported within typed object/array literals Nov 25, 2020
@bradzacher bradzacher merged commit 73a63ee into typescript-eslint:master Nov 25, 2020
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 26, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[explicit-module-boundary-types] does not respect functions exported within array or object literals
2 participants