Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alignment with ESTree class-features #3068

Closed
tchetwin opened this issue Feb 17, 2021 · 2 comments
Closed

Alignment with ESTree class-features #3068

tchetwin opened this issue Feb 17, 2021 · 2 comments
Assignees
@armano2
Labels
AST PRs and Issues about the AST structure breaking change This change will require a new major version to be released package: typescript-estree Issues related to @typescript-eslint/typescript-estree

Comments

@tchetwin
Copy link

tchetwin commented Feb 17, 2021 •
edited by armano2

Following the addition of PrivateIdentifier in #2933 (comment) there remains another (breaking) change to reconcile @typescript-eslint/estree with the ESTree specification, namely: ClassProperty -> PropertyDefinition.

Creating this Issue to track.
@tchetwin tchetwin added package: typescript-estree Issues related to @typescript-eslint/typescript-estree triage Waiting for maintainers to take a look labels Feb 17, 2021
@tchetwin tchetwin mentioned this issue Feb 17, 2021
Closed
2 tasks
@bradzacher bradzacher added AST PRs and Issues about the AST structure breaking change This change will require a new major version to be released and removed triage Waiting for maintainers to take a look labels Feb 17, 2021
@armano2
Copy link
Member

armano2 commented Feb 19, 2021 •
edited

ref: babel/babel#12370

@armano2 armano2 self-assigned this Feb 19, 2021
@armano2 armano2 mentioned this issue Feb 19, 2021
Closed
@bradzacher
Copy link
Member

closing in favour of #3430

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 23, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@armano2 armano2

Labels
AST PRs and Issues about the AST structure breaking change This change will require a new major version to be released package: typescript-estree Issues related to @typescript-eslint/typescript-estree
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: align class property with estree stage3 class-features typescript-eslint/typescript-eslint
3 participants
@armano2 @tchetwin @bradzacher