feat: add stable PrivateIdentifier based on estree spec

[armano2]

Add stable PrivateIdentifier ts-estree base on estree spec,

Due to lack of spec this field field was read as is from typescript,

Changes to produced AST:

value field got renamed to name without initial #

TODO:

• add unit tests for naming-convention rule
• add unit tests for no-unsafe-assignment rule

---

fixes #1436
ref #3430

estree spec: https://github.com/estree/estree/blob/master/experimental/class-features.md

[codecov]

Codecov Report

Merging #2933 (b249029) into v5 (763a252) will decrease coverage by 0.00%.
The diff coverage is 87.50%.

@@            Coverage Diff             @@
##               v5    #2933      +/-   ##
==========================================
- Coverage   92.83%   92.82%   -0.01%     
==========================================
  Files         314      314              
  Lines       10675    10680       +5     
  Branches     3027     3031       +4     
==========================================
+ Hits         9910     9914       +4     
  Misses        348      348              
- Partials      417      418       +1     

Flag	Coverage Δ
unittest	92.82% <87.50%> (-0.01%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
...es/eslint-plugin/src/rules/no-unsafe-assignment.ts	92.43% <0.00%> (-0.79%)	⬇️
packages/eslint-plugin/src/rules/prefer-for-of.ts	90.14% <ø> (ø)
...pt-estree/src/ts-estree/estree-to-ts-node-types.ts	100.00% <ø> (ø)
packages/visitor-keys/src/visitor-keys.ts	100.00% <ø> (ø)
...gin/src/rules/naming-convention-utils/validator.ts	94.44% <100.00%> (+0.03%)	⬆️
...kages/eslint-plugin/src/rules/naming-convention.ts	81.28% <100.00%> (+0.09%)	⬆️
packages/eslint-plugin/src/util/misc.ts	92.85% <100.00%> (+0.26%)	⬆️
packages/typescript-estree/src/convert.ts	98.38% <100.00%> (+<0.01%)	⬆️

[bradzacher]

Based on my discussion with them in estree/estree#240 - I'm happy for us to add these to the AST.
I'd like to wait until we move them from the experimental folder to be 100% certain nothing is going to change (it shouldn't, but better safe than sorry!)
I'll probs raise a PR there on the weekend.

[tchetwin]

@bradzacher I've raised such a PR here: estree/estree#241

Update: Resulted in estree/estree#242 which has now been merged. Full steam ahead!

[tchetwin]

This might make sense in its own Issue rather than this PR, but adding here for continuity of the ESTree class-features spec theme:

Can we reconcile the existing ClassProperty AST node with the ESTree proposed spec which spells it PropertyDefinition?

[bradzacher]

Yes that's definitely on the cards to do soon, but that is a breaking change, so it would be better as a separate change.

[tchetwin]

I've created #3068 to track this following the completion of this PR.
I agree that it would be a breaking change and should be addressed separately.

[bradzacher]

Closing in favour of #3808