Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(eslint-plugin): [no-unnecessary-type-assertion] false positive for null assign to undefined #536

Merged
merged 2 commits into from Jun 7, 2019
Merged

fix(eslint-plugin): [no-unnecessary-type-assertion] false positive for null assign to undefined #536

merged 2 commits into from Jun 7, 2019

Conversation

bradzacher
Copy link
Member

Fixes #529

Strict mode doesn't let you assign a null to an undefined.
This fixes the check to make sure the two types share a nullable type.

@bradzacher bradzacher added the bug Something isn't working label May 16, 2019
@bradzacher bradzacher mentioned this pull request May 16, 2019
Merged
@bradzacher bradzacher merged commit b16409a into master Jun 7, 2019
@bradzacher bradzacher deleted the nuta-1 branch June 7, 2019 04:26
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JamesHenry JamesHenry JamesHenry approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[no-unnecessary-type-assertion] false positive when asserting via non-null assertion operator
2 participants
@bradzacher @JamesHenry