Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin): [no-unnecessary-type-assertion] handle missing declarations #537

Merged
merged 4 commits into from Jun 9, 2019

Conversation

bradzacher
Copy link
Member

@bradzacher bradzacher commented May 16, 2019

Fixes #532

The example in the issue works fine as long as all the required declarations are attached.
If something is missing, then it breaks because the code was assuming valid typescript.

@bradzacher bradzacher added bug Something isn't working blocked by another PR PRs which are ready to go but waiting on another PR labels May 16, 2019
@bradzacher bradzacher changed the base branch from master to nuta-1 May 16, 2019 17:48
@bradzacher bradzacher changed the base branch from nuta-1 to master June 7, 2019 04:26
@bradzacher bradzacher removed the blocked by another PR PRs which are ready to go but waiting on another PR label Jun 7, 2019
@codecov
Copy link

codecov bot commented Jun 7, 2019

Codecov Report

Merging #537 into master will decrease coverage by 0.03%.
The diff coverage is 77.77%.

@@            Coverage Diff             @@
##           master     #537      +/-   ##
==========================================
- Coverage   94.15%   94.12%   -0.04%     
==========================================
  Files         104      104              
  Lines        4263     4271       +8     
  Branches     1163     1166       +3     
==========================================
+ Hits         4014     4020       +6     
- Misses        145      146       +1     
- Partials      104      105       +1
Impacted Files Coverage Δ
...-plugin/src/rules/no-unnecessary-type-assertion.ts 90.78% <100%> (+0.24%) ⬆️
packages/eslint-plugin/src/util/types.ts 78.78% <71.42%> (-1.22%) ⬇️

@JamesHenry JamesHenry merged commit c69f4b7 into master Jun 9, 2019
@JamesHenry JamesHenry deleted the nuta-2 branch June 9, 2019 19:57
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 21, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[no-unnecessary-type-assertion] "Cannot read property 'declarations' of undefined" in decorator call
2 participants